Opened 8 years ago

Closed 7 years ago

#2846 closed enhancement (wontfix)

g.gui.rlisetup: show where new config file is created

Reported by: hellik Owned by: grass-dev@…
Priority: normal Milestone: 7.4.0
Component: Raster Version: svn-releasebranch70
Keywords: Cc:
CPU: Unspecified Platform: Unspecified

Description

hi,

I've tested g.gui.rlisetup in

GRASS version: 7.0.3RC1                                                         
GRASS SVN Revision: 67443                                                       
Build Date: 2015-12-31                                                          
Build Platform: i386-w64-mingw32                                                
GDAL/OGR: 1.11.3                                                                
PROJ.4: 4.9.2                                                                   
GEOS: 3.5.0                                                                     
SQLite: 3.7.17                                                                  
Python: 2.7.4                                                                   
wxPython: 2.8.12.1                                                              
Platform: Windows-7-6.1.7601-SP1 (OSGeo4W)   

after finishing g.gui.rlisetup there is a message the the user defined config file is created, but there is no information about the path to the config file.

in windows it is e.g.

C:\Users\xxx\AppData\Roaming\GRASS7\r.li

it would be nice if there would be an information of the whole path to the file which could be copy/paste as input to the r.li.*-modules.

Change History (14)

comment:1 by neteler, 8 years ago

I suppose that a respective grass.message() statement is needed in

gui/wxpython/rlisetup/wizard.py, line 135

in reply to:  description ; comment:2 by mlennert, 8 years ago

Replying to hellik:

it would be nice if there would be an information of the whole path to the file which could be copy/paste as input to the r.li.*-modules.

You should not use the absolute path in the r.li.* modules. Just the file name. You can list existing files with g.gui.rlisetup. So, normally, no need to see the absolute path.

However, ascii output files are also stored in the same path, and this is a bit more of a nuisance as you then have to navigate there to find the file. I imagine (but haven't checked) that this was done to ensure that any other r.li.* module can potentially, easily find the ascii output of another, but are there many modules that read this kind of output ?

In any case, though, all modules give the info of the standard path in their manual. Ex for r.li.padsd:

"[...] otherwise an ASCII file will be generated in the folder C:\Users\userxy\AppData\Roaming\GRASS7\r.li\output\ (MS-Windows) or $HOME/.grass7/r.li/output/ (GNU/Linux)."

in reply to:  2 ; comment:3 by lucadelu, 8 years ago

Replying to mlennert:

Replying to hellik:

it would be nice if there would be an information of the whole path to the file which could be copy/paste as input to the r.li.*-modules.

You should not use the absolute path in the r.li.* modules. Just the file name. You can list existing files with g.gui.rlisetup. So, normally, no need to see the absolute path.

I confirm this

However, ascii output files are also stored in the same path, and this is a bit more of a nuisance as you then have to navigate there to find the file. I imagine (but haven't checked) that this was done to ensure that any other r.li.* module can potentially, easily find the ascii output of another, but are there many modules that read this kind of output ?

Maybe you can open an enhancement ticket for this? Can I suggest to close this ticket as invalid? I think it is better to use g.gui.rlisetup to create or modify the r.li configuration files.

in reply to:  3 ; comment:4 by hellik, 8 years ago

Replying to lucadelu:

Replying to mlennert:

Replying to hellik:

it would be nice if there would be an information of the whole path to the file which could be copy/paste as input to the r.li.*-modules.

You should not use the absolute path in the r.li.* modules. Just the file name. You can list existing files with g.gui.rlisetup. So, normally, no need to see the absolute path.

I confirm this

However, ascii output files are also stored in the same path, and this is a bit more of a nuisance as you then have to navigate there to find the file. I imagine (but haven't checked) that this was done to ensure that any other r.li.* module can potentially, easily find the ascii output of another, but are there many modules that read this kind of output ?

Maybe you can open an enhancement ticket for this? Can I suggest to close this ticket as invalid? I think it is better to use g.gui.rlisetup to create or modify the r.li configuration files.

What kind of invalid is to show the path to config (and maybe the output) files?

in reply to:  4 ; comment:5 by mlennert, 8 years ago

Replying to hellik:

Replying to lucadelu:

Replying to mlennert:

Replying to hellik:

it would be nice if there would be an information of the whole path to the file which could be copy/paste as input to the r.li.*-modules.

You should not use the absolute path in the r.li.* modules. Just the file name. You can list existing files with g.gui.rlisetup. So, normally, no need to see the absolute path.

I confirm this

However, ascii output files are also stored in the same path, and this is a bit more of a nuisance as you then have to navigate there to find the file. I imagine (but haven't checked) that this was done to ensure that any other r.li.* module can potentially, easily find the ascii output of another, but are there many modules that read this kind of output ?

Maybe you can open an enhancement ticket for this? Can I suggest to close this ticket as invalid? I think it is better to use g.gui.rlisetup to create or modify the r.li configuration files.

What kind of invalid is to show the path to config (and maybe the output) files?

I think that a message with the full path will give the illusion that this is what users should use, while what they actually should use is just the name. Maybe to make that even clearer, the r.li.* modules should provide a dropdown list of available config files (such as the list of signature files you can get in i.maxlik). Again, something for an enhancement ticket.

So, maybe invalid is a bit harsh, and wontfix is better, but I agree with Luca on the conclusion.

comment:6 by martinl, 8 years ago

Milestone: 7.0.47.0.5

comment:7 by martinl, 8 years ago

Milestone: 7.0.57.3.0

comment:8 by martinl, 8 years ago

Milestone: 7.3.07.4.0

Milestone renamed

comment:9 by lucadelu, 7 years ago

Resolution: wontfix
Status: newclosed

No reply after 7 months, please reopen if needed

in reply to:  9 ; comment:10 by hellik, 7 years ago

Resolution: wontfix
Status: closedreopened

Replying to lucadelu:

No reply after 7 months, please reopen if needed

just tested the example from the r.li-manual

  • created the config-file by g.gui.rlisetup
  • closing g.gui.rlisetup-GUI
  • starting the r.li.patchdensity-GUI
  • then in the r.li.patchdensity-GUI regarding for config-file I have to browse through the file system to the config file

but I from a user perspective: you don't know where to browse to the config file, as there is no information where the config file was created.

reopening the ticket, as there is actually a lack of information where to browse.

in reply to:  5 comment:11 by hellik, 7 years ago

Replying to mlennert:

Replying to hellik:

Replying to lucadelu:

Replying to mlennert:

Replying to hellik:

it would be nice if there would be an information of the whole path to the file which could be copy/paste as input to the r.li.*-modules.

You should not use the absolute path in the r.li.* modules. Just the file name. You can list existing files with g.gui.rlisetup. So, normally, no need to see the absolute path.

I confirm this

However, ascii output files are also stored in the same path, and this is a bit more of a nuisance as you then have to navigate there to find the file. I imagine (but haven't checked) that this was done to ensure that any other r.li.* module can potentially, easily find the ascii output of another, but are there many modules that read this kind of output ?

Maybe you can open an enhancement ticket for this? Can I suggest to close this ticket as invalid? I think it is better to use g.gui.rlisetup to create or modify the r.li configuration files.

What kind of invalid is to show the path to config (and maybe the output) files?

I think that a message with the full path will give the illusion that this is what users should use, while what they actually should use is just the name. Maybe to make that even clearer, the r.li.* modules should provide a dropdown list of available config files (such as the list of signature files you can get in i.maxlik). Again, something for an enhancement ticket.

a dropdown list would be indeed the best solution.

So, maybe invalid is a bit harsh, and wontfix is better, but I agree with Luca on the conclusion.

as long there is no dropdown list, IMHO the user is left alone to know names if there are several config files.

in reply to:  10 ; comment:12 by lucadelu, 7 years ago

Replying to hellik:

but I from a user perspective: you don't know where to browse to the config file, as there is no information where the config file was created.

reopening the ticket, as there is actually a lack of information where to browse.

the problem is not related to g.gui.rlisetup, so please close this ticket and fill new one

in reply to:  12 comment:13 by hellik, 7 years ago

Replying to lucadelu:

Replying to hellik:

but I from a user perspective: you don't know where to browse to the config file, as there is no information where the config file was created.

reopening the ticket, as there is actually a lack of information where to browse.

the problem is not related to g.gui.rlisetup, so please close this ticket and fill new one

done by #3228

comment:14 by hellik, 7 years ago

Resolution: wontfix
Status: reopenedclosed
Note: See TracTickets for help on using tickets.