Opened 5 years ago

Closed 5 years ago

#2801 closed defect (fixed)

wxGUI modeler: overwrite flag not saved when reopening module dialog

Reported by: mlennert Owned by: martinl
Priority: normal Milestone: 7.0.3
Component: wxGUI Version: 7.0.1
Keywords: modeler overwrite flag Cc: grass-dev@…
CPU: Unspecified Platform: Unspecified

Description

In the GUI modeler:

  • add any module
  • in the module dialogue check the overwrite flag checkbox
  • close the module dialogue
  • reopen the module dialogue

Result: the overwrite flag is not checked anymore. You have to explicitely set the flag everytime you reopen a module dialogue. Very annoying...

I have this issue in 7.0.1 and cannot verify whether this is also an issue in trunk because of #2800.

Change History (8)

comment:1 Changed 5 years ago by martinl

There were two issues - wxGUI part fixed in r66941. Moreover G_recreate_command() ignored global options (like --overwrite), this issue is fixed r66940. After some testing I will backport both changes to relbr70.

comment:2 in reply to:  description ; Changed 5 years ago by martinl

Replying to mlennert:

Result: the overwrite flag is not checked anymore. You have to explicitely set the flag everytime you reopen a module dialogue. Very annoying...

Please note that you can set overwrite globally for model in Model -> Properties (Graphical Modeler) or for whole GUI in GUI Preferences -> Modules (Layer Manager).

comment:3 Changed 5 years ago by martinl

Cc: grass-dev@… added
Owner: changed from grass-dev@… to martinl
Status: newassigned

comment:4 in reply to:  2 ; Changed 5 years ago by wenzeslaus

Replying to martinl:

Replying to mlennert:

Result: the overwrite flag is not checked anymore. You have to explicitely set the flag everytime you reopen a module dialogue. Very annoying...

Please note that you can set overwrite globally for model in Model -> Properties (Graphical Modeler) or for whole GUI in GUI Preferences -> Modules (Layer Manager).

BTW, I think the global settings is a best practice and should be preferred.

comment:5 in reply to:  4 ; Changed 5 years ago by mlennert

Replying to wenzeslaus:

Replying to martinl:

Replying to mlennert:

Result: the overwrite flag is not checked anymore. You have to explicitely set the flag everytime you reopen a module dialogue. Very annoying...

Please note that you can set overwrite globally for model in Model -> Properties (Graphical Modeler) or for whole GUI in GUI Preferences -> Modules (Layer Manager).

BTW, I think the global settings is a best practice and should be preferred.

Are you speaking about the global setting in the modeler or for the whole GUI ?

In both cases I strongly disagree. IMHO, automatic overwrite should not be the default setting. It should always be a deliberate choice by the user.

Thank you for the fixes, Martin, I'll test as soon as possible.

Moritz

comment:6 in reply to:  1 Changed 5 years ago by mlennert

Replying to martinl:

There were two issues - wxGUI part fixed in r66941. Moreover G_recreate_command() ignored global options (like --overwrite), this issue is fixed r66940. After some testing I will backport both changes to relbr70.

A quick test shows that both the modeler fix and the general lib fix seem to work here.

Moritz

comment:7 in reply to:  5 Changed 5 years ago by wenzeslaus

Replying to mlennert:

Replying to wenzeslaus:

Replying to martinl:

Replying to mlennert:

Result: the overwrite flag is not checked anymore. You have to explicitely set the flag everytime you reopen a module dialogue. Very annoying...

Please note that you can set overwrite globally for model in Model -> Properties (Graphical Modeler) or for whole GUI in GUI Preferences -> Modules (Layer Manager).

BTW, I think the global settings is a best practice and should be preferred.

Are you speaking about the global setting in the modeler or for the whole GUI ?

In both cases I strongly disagree. IMHO, automatic overwrite should not be the default setting. It should always be a deliberate choice by the user.

Model -> Properties applies just to the current model (global for the whole model), right? If the alternative is overwrite checked for every individual module, then yes, I think it is better.

comment:8 in reply to:  1 Changed 5 years ago by martinl

Resolution: fixed
Status: assignedclosed

Replying to martinl:

There were two issues - wxGUI part fixed in r66941. Moreover G_recreate_command() ignored global options (like --overwrite), this issue is fixed r66940. After some testing I will backport both changes to relbr70.

Both issues backported (r67374 and r66981). Closing this ticket, feel free to reopen if needed.

Note: See TracTickets for help on using tickets.