Opened 4 years ago

Closed 21 months ago

#2790 closed defect (fixed)

Output of t.rast.list with method=comma and columns=name does not differ from output with columns=id

Reported by: veroandreo Owned by: grass-dev@…
Priority: normal Milestone: 7.4.1
Component: Temporal Version: svn-trunk
Keywords: t.rast.list, t.vect.list Cc:
CPU: x86-64 Platform: Linux

Description

Hi,

When using t.rast.list column=name method=comma, both map name and mapset name are printed, so it does not differ from asking column=id.

GRASS 7.1.svn (latlong_wgs84):~ > t.rast.list input=precip_abs order=start_time columns=name method=comma
prec_1@pruebas,prec_2@pruebas,prec_3@pruebas,prec_4@pruebas,prec_5@pruebas,prec_6@pruebas,prec_7@pruebas,prec_8@pruebas,prec_9@pruebas,prec_10@pruebas,prec_11@pruebas,prec_12@pruebas
GRASS 7.1.svn (latlong_wgs84):~ > t.rast.list input=precip_abs order=start_time columns=id method=comma
prec_1@pruebas,prec_2@pruebas,prec_3@pruebas,prec_4@pruebas,prec_5@pruebas,prec_6@pruebas,prec_7@pruebas,prec_8@pruebas,prec_9@pruebas,prec_10@pruebas,prec_11@pruebas,prec_12@pruebas

While several modules (r.colors, r.stats or r.series) can take this as input, r.hants (from add-ons) gives an error

GRASS 7.1.svn (latlong_wgs84):~ > r.hants input=`t.rast.list input=precip_abs order=start_time columns=name method=comma` nf=2
base_period=6 fet=10 suffix=_hants

ERROR: Raster map <prec_1@pruebas_hants> is not in the current mapset
       (pruebas)

For r.hants it's of main importance that maps are temporally ordered and that's why I would prefer to use t.rast.list that orders maps as needed (instead of g.list, that depending on map names, could give a wrong order), but as the output includes "@mapset_name", maps are no longer recognized.

Thanks a lot in advance :)

Change History (12)

comment:1 Changed 4 years ago by veroandreo

Milestone: 7.0.3

comment:2 Changed 4 years ago by neteler

Milestone: 7.0.3

Ticket retargeted after milestone closed

comment:3 Changed 4 years ago by neteler

Milestone: 7.0.4

Ticket retargeted after 7.0.3 milestone closed

comment:4 Changed 4 years ago by martinl

Milestone: 7.0.47.0.5

comment:5 Changed 3 years ago by neteler

Milestone: 7.0.57.0.6

comment:6 in reply to:  description Changed 2 years ago by mmetz

Replying to veroandreo:

Hi,

When using t.rast.list column=name method=comma, both map name and mapset name are printed, so it does not differ from asking column=id.

GRASS 7.1.svn (latlong_wgs84):~ > t.rast.list input=precip_abs order=start_time columns=name method=comma
prec_1@pruebas,prec_2@pruebas,prec_3@pruebas,prec_4@pruebas,prec_5@pruebas,prec_6@pruebas,prec_7@pruebas,prec_8@pruebas,prec_9@pruebas,prec_10@pruebas,prec_11@pruebas,prec_12@pruebas
GRASS 7.1.svn (latlong_wgs84):~ > t.rast.list input=precip_abs order=start_time columns=id method=comma
prec_1@pruebas,prec_2@pruebas,prec_3@pruebas,prec_4@pruebas,prec_5@pruebas,prec_6@pruebas,prec_7@pruebas,prec_8@pruebas,prec_9@pruebas,prec_10@pruebas,prec_11@pruebas,prec_12@pruebas

While several modules (r.colors, r.stats or r.series) can take this as input, r.hants (from add-ons) gives an error

GRASS 7.1.svn (latlong_wgs84):~ > r.hants input=`t.rast.list input=precip_abs order=start_time columns=name method=comma` nf=2
base_period=6 fet=10 suffix=_hants

ERROR: Raster map <prec_1@pruebas_hants> is not in the current mapset
       (pruebas)

The fully qualified input names where used to construct output names. Fixed for both r.hants and r.series.lwr in r71682.

comment:7 Changed 2 years ago by veroandreo

Thanks for the fix! I tested both r.hants and r.series.lwr and all goes fine.

I keep this one open, because the output of G7:t.rast.list using column=name or column=id with method=comma gives the same output mapname@mapset, while it should be only the map name when column=name is used.

comment:8 Changed 22 months ago by neteler

Milestone: 7.0.67.0.7

comment:9 Changed 21 months ago by veroandreo

Keywords: t.vect.list added
Milestone: 7.0.77.4.1

This issue also applies to G7:t.vect.list, i.e., the output of:

t.vect.list input=bushfires_yearly method=comma columns=id

and

t.vect.list input=bushfires_yearly method=comma columns=name

is exactly the same, while indeed the second command should output only the stvds name without the "@mapsename" part.

comment:10 Changed 21 months ago by lucadelu

Resolution: fixed
Status: newclosed

In 72403:

python temporal: fix #2790

comment:11 Changed 21 months ago by martinl

Resolution: fixed
Status: closedreopened

The milestone is set to 7.4.1. What about backports?

comment:12 Changed 21 months ago by lucadelu

Resolution: fixed
Status: reopenedclosed

backported in r72502 and r72503

Note: See TracTickets for help on using tickets.