Drop menu file in favor of desktop file

[Bas Couwenberg]

The menu files are no longer required for the Debian packages since ​CTTE #741573 - Debian Menu System which advised:

In addition to those changes, the Technical Committee resolves that packages providing a .desktop file shall not also provide a menu file for the same application.

In the attached patch the menu file and its associated XPM icon are removed, leaving the desktop file and its associated PNG icons in its place.

The PNG icons are installed in the hicolor theme following the ​Icon Theme Specification:

So, you're an application author, and want to install application icons so that they work in the KDE and Gnome menus. Minimally you should install a 48x48 icon in the hicolor theme. This means installing a PNG file in $prefix/share/icons/hicolor/48x48/apps. Optionally you can install icons in different sizes. For example, installing a svg icon in $prefix/share/icons/hicolor/scalable/apps means most desktops will have one icon that works for all sizes. You might even want to install icons with a look that matches other well known themes so your application will fit in with some specific desktop environment.

The SVG icon (grasslogo_vector.svg) is also installed to have an icon for all size besides 48x48 & 64x64.

[Bas Couwenberg]

To make use of the changes in ctte-741573.patch​ in the ​grass Debian packaging on Launchpad, have a look at the packaging changes in the ​Use desktop file in favor of menu file per CTTE #741573. commit in the Debian GIS git repository.

[Bas Couwenberg]

This didn't make it into 7.0.2RC2, can we get it into RC3 or 7.0.2 final?

[neteler]

Replying to sebastic:

This didn't make it into 7.0.2RC2, can we get it into RC3 or 7.0.2 final?

Is it generic or Debian specific? We also support Fedora, Gentoo, other (Linux and non) distros.

From the provided patch I am not able to judge that.

[Bas Couwenberg]

It's generic, it applies to all systems implementing the Freedesktop.org standards.

Because GRASS now installs the hicolor icons, the distribution packaging can use that instead of its own.

Only dropping the menu files and its associated xpm icon is Debian specific. This just makes the Freedesktop.org standards more important.

[Bas Couwenberg]

Because ctte-741573.patch​ installs the icons as grass70.{png,svg} the Icon field in the desktop file also needs to changed to grass70 as done in desktop.patch.

[neteler]

desktop.patch​ applied in r66865 (trunk) and r66866 (relbr70).

From ctte-741573.patch​ I understand that the file grass.menu + grass.xpm shall be removed rather than emptied. Done in r66867. If that's right, r66867 needs to be backported.

[Bas Couwenberg]

Yes, the menu file and its associated XPM icon are no longer required and are removed by the patch.

r66867 is appropriate for r66866 because they both reference the grass70 icon, in trunk the icons need to be installed as grass71.{svg,png} to match r66865.

[neteler]

Replying to sebastic:

r66867 is appropriate for r66866 because they both reference the grass70 icon,

backported in r66875.

in trunk the icons need to be installed as grass71.{svg,png} to match r66865.

Ah right. Fixed in r66876.

closing.