Opened 4 years ago

Closed 4 years ago

#2723 closed defect (fixed)

error when running v.krige

Reported by: pvanbosgeo Owned by: grass-dev@…
Priority: normal Milestone: 7.0.1
Component: Default Version: svn-trunk
Keywords: Cc:
CPU: Unspecified Platform: Linux

Description

When I use the "plot/refresh variogram" button, I am getting an error message:

Command: v.out.ogr 
... usual text about v.out.ogr
...

/usr/lib/python2.7/dist-packages/rpy2/robjects/functions.py:106: UserWarning: Error in insert_required(pcmd = pcmd, parameters = parameters, pt = pt,  : 
  required parameters with no defaults missing: output

  res = super(Function, self).__call__(*new_args, **new_kwargs)
Traceback (most recent call last):
  File "/usr/local/grass7/grass-7.1.svn/gui/wxpython/modules/vkrige.py", line 456, in OnPlotButton
    column = column)
  File "/usr/local/grass7/grass-7.1.svn/scripts/v.krige", line 143, in ImportMap
    Rpointmap = robjects.r.readVECT6(map, type =  'point')
  File "/usr/lib/python2.7/dist-packages/rpy2/robjects/functions.py", line 178, in __call__
    return super(SignatureTranslatedFunction, self).__call__(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/rpy2/robjects/functions.py", line 106, in __call__
    res = super(Function, self).__call__(*new_args, **new_kwargs)
rpy2.rinterface.RRuntimeError: Error in insert_required(pcmd = pcmd, parameters = parameters, pt = pt,  : 
  required parameters with no defaults missing: output

I am getting a similar error message when running the kriging module using

Attachments (2)

v.krige.patch (1.7 KB) - added by pvanbosgeo 4 years ago.
changes to make the script work with the R package rgrass7
v.krige.html.patch (4.4 KB) - added by pvanbosgeo 4 years ago.
Corrections, mostly to reflect the change in dependency from spgrass6 to rgrass7

Download all attachments as: .zip

Change History (6)

comment:1 Changed 4 years ago by neteler

Milestone: 7.0.1

I briefly looked at the code.

gui/wxpython/modules/vkrige.py:            self.controller.InputData = self.controller.ImportMap(map = map,

calls

scripts/v.krige/v.krige.py:    def ImportMap(self, map, column):

which calls

Rpointmap = robjects.r.readVECT6(map, type =  'point')

which ain't work with rgrass7. In essence, scripts/v.krige/v.krige.py needs to be updated to rgrass7 (not a complicated task at all).

Changed 4 years ago by pvanbosgeo

Attachment: v.krige.patch added

changes to make the script work with the R package rgrass7

comment:2 Changed 4 years ago by pvanbosgeo

You are right Markus, just added a patch file that seems to resolve the problem with "plot/refresh variogram" when running with rgrass7.

comment:3 Changed 4 years ago by neteler

Thanks, patch applied in r66386.

Would you mind to also update the HTML page?

Changed 4 years ago by pvanbosgeo

Attachment: v.krige.html.patch added

Corrections, mostly to reflect the change in dependency from spgrass6 to rgrass7

comment:4 Changed 4 years ago by neteler

Resolution: fixed
Status: newclosed

Submitted in r66388 and all backported to 7.0.svn in r66391.

Closing.

Note: See TracTickets for help on using tickets.