Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#2694 closed defect (fixed)

rendering command layer and adding 3d raster layer broken

Reported by: annakrat Owned by: martinl
Priority: normal Milestone: 7.2.0
Component: wxGUI Version: svn-trunk
Keywords: rendering Cc: grass-dev@…
CPU: Unspecified Platform: Linux

Description

Two issues I found with the new rendering with the less often used cases:

  1. adding 3D raster layer breaks rendering, although there is no error, rendering just stops working after that and busy cursors stays there. I was trying to fix this one, but was not able to get rid of the progress bar which was still showing up:
Index: core/render.py
===================================================================
--- core/render.py      (revision 65443)
+++ core/render.py      (working copy)
@@ -472,6 +472,8 @@
         # render map layers if forced
         nlayers = 0
         for layer in self.layers:
+            if layer.GetType() == '3d-raster':
+                continue
             if force or layer.forceRender:
                 nlayers += 1
                 layer.Render(env)
@@ -532,6 +534,8 @@
         for layer in self.layers:
             if layer.GetType() == 'overlay':
                 continue
+            if layer.GetType() == '3d-raster':
+                continue
 
             if os.path.isfile(layer.mapfile):
                 maps.append(layer.mapfile)

  1. Rendering command layers is weird, (un)checking has no effect.

Change History (6)

comment:1 in reply to:  description ; Changed 4 years ago by martinl

Replying to annakrat:

  1. adding 3D raster layer breaks rendering, although there is no error, rendering just stops working after that and busy cursors stays there. I was trying to fix this one, but was not able to get rid of the progress bar which was still showing up:

please try out r65450

  1. Rendering command layers is weird, (un)checking has no effect.

I would suggest to remove command layers from wxGUI completely, what do you think?

comment:2 Changed 4 years ago by martinl

Cc: grass-dev@… added
Owner: changed from grass-dev@… to martinl
Status: newassigned

comment:3 in reply to:  1 ; Changed 4 years ago by annakrat

Replying to martinl:

Replying to annakrat:

  1. adding 3D raster layer breaks rendering, although there is no error, rendering just stops working after that and busy cursors stays there. I was trying to fix this one, but was not able to get rid of the progress bar which was still showing up:

please try out r65450

Thank you, works nicely

  1. Rendering command layers is weird, (un)checking has no effect.

I would suggest to remove command layers from wxGUI completely, what do you think?

Hm, I was actually using it. For example you can have multiple legends with command layers and you can save them to workspace. But that's workaround for not having a way to display multiple legends.

comment:4 in reply to:  3 Changed 4 years ago by annakrat

Replying to annakrat:

I would suggest to remove command layers from wxGUI completely, what do you think?

Hm, I was actually using it. For example you can have multiple legends with command layers and you can save them to workspace. But that's workaround for not having a way to display multiple legends.

I realized d.histogram is not working when called from Map Display toolbar. It seems that it actually uses the command layers.

comment:5 Changed 4 years ago by annakrat

Resolution: fixed
Status: assignedclosed

This seems to work now, not sure which change fixed it.

comment:6 Changed 4 years ago by neteler

Milestone: 7.1.07.2.0

Milestone renamed

Note: See TracTickets for help on using tickets.