Opened 4 years ago

Closed 4 years ago

#2690 closed enhancement (fixed)

PEP8 like code styling for the i.tasscap.py script

Reported by: Nikos Alexandris Owned by: grass-dev@…
Priority: trivial Milestone: 7.0.1
Component: Python Version: unspecified
Keywords: i.tassccap, python, script Cc:
CPU: Unspecified Platform: Unspecified

Description

See attached diff.

Attachments (3)

i.tasscap.py.diff (11.5 KB) - added by Nikos Alexandris 4 years ago.
i.tasscap.py.diff_ignore-all-space (8.9 KB) - added by Nikos Alexandris 4 years ago.
i.tasscap.py.diff_ignore-space-change (11.5 KB) - added by Nikos Alexandris 4 years ago.

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by Nikos Alexandris

Attachment: i.tasscap.py.diff added

comment:1 Changed 4 years ago by wenzeslaus

Seems OK. Did you check what you get from svn diff --ignore-space-change or svn diff --ignore-all-space?

I was not sure about the header but now I see that it fits with wiki:Submitting/Python. I'm glad that to learn that. I wonder how it looks like when it gets through Sphinx (not that we would doing that).

I would ask you for simple test which would prove that the basic functionality is OK but it would be probably absurd to require it when we lack tests for far more invasive changes.

Changed 4 years ago by Nikos Alexandris

Changed 4 years ago by Nikos Alexandris

comment:2 in reply to:  1 Changed 4 years ago by Nikos Alexandris

Replying to wenzeslaus:

Seems OK. Did you check what you get from svn diff --ignore-space-change or svn diff --ignore-all-space?

Attached diffs derived from svn diff -x '--ignore-all-space' and svn diff -x '--ignore-space-change'.

I would ask you for simple test which would prove that the basic functionality is OK but it would be probably absurd to require it when we lack tests for far more invasive changes.

At minimum, I have tested the script before submitting the (first) diff and it work-ed/-s for me.

comment:3 Changed 4 years ago by lucadelu

Resolution: fixed
Status: newclosed

Fixed in r65674 and r65675

Note: See TracTickets for help on using tickets.