Opened 5 years ago
Closed 5 years ago
#2690 closed enhancement (fixed)
PEP8 like code styling for the i.tasscap.py script
| Reported by: | Nikos Alexandris | Owned by: | |
|---|---|---|---|
| Priority: | trivial | Milestone: | 7.0.1 |
| Component: | Python | Version: | unspecified |
| Keywords: | i.tassccap, python, script | Cc: | |
| CPU: | Unspecified | Platform: | Unspecified |
Description
See attached diff.
Attachments (3)
Change History (6)
Changed 5 years ago by
| Attachment: | i.tasscap.py.diff added |
|---|
comment:1 follow-up: 2 Changed 5 years ago by
Changed 5 years ago by
| Attachment: | i.tasscap.py.diff_ignore-all-space added |
|---|
Changed 5 years ago by
| Attachment: | i.tasscap.py.diff_ignore-space-change added |
|---|
comment:2 Changed 5 years ago by
Replying to wenzeslaus:
Seems OK. Did you check what you get from
svn diff --ignore-space-changeorsvn diff --ignore-all-space?
Attached diffs derived from svn diff -x '--ignore-all-space' and svn diff -x '--ignore-space-change'.
I would ask you for simple test which would prove that the basic functionality is OK but it would be probably absurd to require it when we lack tests for far more invasive changes.
At minimum, I have tested the script before submitting the (first) diff and it work-ed/-s for me.
comment:3 Changed 5 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
Seems OK. Did you check what you get from
svn diff --ignore-space-changeorsvn diff --ignore-all-space?I was not sure about the header but now I see that it fits with wiki:Submitting/Python. I'm glad that to learn that. I wonder how it looks like when it gets through Sphinx (not that we would doing that).
I would ask you for simple test which would prove that the basic functionality is OK but it would be probably absurd to require it when we lack tests for far more invasive changes.