Opened 4 years ago

Closed 3 years ago

#2664 closed defect (fixed)

The r.watershed module documentation has the wrong value for cells that do not get included in a complete watershed.

Reported by: swendel621 Owned by: grass-dev@…
Priority: normal Milestone: 7.0.5
Component: Docs Version: 7.0.0
Keywords: r.watershed, basin, doc Cc:
CPU: All Platform: All

Description

In the current online r.watershed module's help documentation, there is a conflicting statement to the output generated for the basin parameter.

http://grass.osgeo.org/grass71/manuals/r.watershed.html

In the text it says, "0 values indicate that the cell is not part of a complete watershed basin in the current geographic region."

If I run r.watershed on the Elevation sample data and set the threshold to 10000, the output basin will have areas on the edges that do not generate a basin. The values of these areas are null instead of 0 like the documentation makes it sounds like it should get. It makes sense for the values to be null instead of 0 so the documentation needs to be updated.

Change History (9)

comment:1 Changed 4 years ago by neteler

Milestone: 7.0.17.0.2

Ticket retargeted after 7.0.1 milestone closed

comment:2 Changed 4 years ago by neteler

Milestone: 7.0.27.0.3

Ticket retargeted after milestone closed

comment:3 Changed 3 years ago by neteler

Milestone: 7.0.3

Ticket retargeted after milestone closed

comment:4 Changed 3 years ago by neteler

Milestone: 7.0.4

Ticket retargeted after 7.0.3 milestone closed

comment:5 in reply to:  description Changed 3 years ago by mmetz

Replying to swendel621:

In the current online r.watershed module's help documentation, there is a conflicting statement to the output generated for the basin parameter.

http://grass.osgeo.org/grass71/manuals/r.watershed.html

In the text it says, "0 values indicate that the cell is not part of a complete watershed basin in the current geographic region."

If I run r.watershed on the Elevation sample data and set the threshold to 10000, the output basin will have areas on the edges that do not generate a basin. The values of these areas are null instead of 0 like the documentation makes it sounds like it should get. It makes sense for the values to be null instead of 0 so the documentation needs to be updated.

Manual updated in trunk r67920.

comment:6 Changed 3 years ago by martinl

Milestone: 7.0.47.0.5

comment:7 Changed 3 years ago by martinl

Should be backported to relbr70?

comment:8 in reply to:  7 Changed 3 years ago by annakrat

Replying to martinl:

Should be backported to relbr70?

Please go ahead.

comment:9 Changed 3 years ago by martinl

Resolution: fixed
Status: newclosed

In 69238:

The r.watershed module documentation has the wrong value for cells that do not get included in a complete watershed. (fix #2664)

Note: See TracTickets for help on using tickets.