Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#2577 closed defect (fixed)

d.info: entire screen version frame

Reported by: martinl Owned by: grass-dev@…
Priority: normal Milestone: 7.0.1
Component: Display Version: svn-trunk
Keywords: d.info, d.rast.leg Cc:
CPU: Unspecified Platform: Unspecified

Description

It seems that d.info reports wrong values when GRASS_RENDER_FRAME is defined, if I understand well -r should return (entire) screen rectangle and -f active frame rectangle.

Example:

export GRASS_RENDER_IMMEDIATE=cairo
export GRASS_RENDER_WIDTH=600
export GRASS_RENDER_HEIGHT=540

No frames involved:

d.info -r
rectangle: 0.000000 600.000000 0.000000 540.000000
d.info -f
frame: 0.000000 600.000000 0.000000 540.000000

Define frame:

export GRASS_RENDER_FRAME=270,540,0,300

OK:

d.info -f
frame: 0.000000 300.000000 270.000000 540.000000

Here I would expect the entire screen:

d.info -r
rectangle: 0.000000 300.000000 270.000000 540.000000

?

Martin

Change History (6)

comment:1 Changed 5 years ago by glynn

This stems from r62026. At present, there is no way to retrieve the screen bounds, only the frame bounds. Previously, it was the other way around.

comment:2 in reply to:  1 Changed 5 years ago by martinl

Replying to glynn:

This stems from r62026. At present, there is no way to retrieve the screen bounds, only the frame bounds. Previously, it was the other way around.

It's pity. Would be possible to change that? If not I would suggest to clean up at least d.info flags.

comment:3 in reply to:  1 ; Changed 5 years ago by glynn

Replying to glynn:

This should be fixed by r64459. This adds the -e flag to query the dimensions of the frame (-d queries the dimensions of the screen).

This also fixes the behaviour of d.info -g, which was wrong before r62026.

Also, I don't think that the MONITOR stuff belongs in d.info. It should probably go into d.mon.

comment:4 in reply to:  3 ; Changed 5 years ago by martinl

Replying to glynn:

This should be fixed by r64459. This adds the -e flag to query the dimensions of the frame (-d queries the dimensions of the screen).

This also fixes the behaviour of d.info -g, which was wrong before r62026.

Thanks a lot for the fixes. They are hot candidates for backport to relbr70 (before closing this ticket).

Also, I don't think that the MONITOR stuff belongs in d.info. It should probably go into d.mon.

Right, removed from d.info in r64466.

comment:5 in reply to:  4 Changed 5 years ago by martinl

Resolution: fixed
Status: newclosed

Replying to martinl:

Thanks a lot for the fixes. They are hot candidates for backport to relbr70 (before closing this ticket).

I have taken liberty to backport it in r64472. Closing this ticket as fixed.

comment:6 Changed 5 years ago by neteler

Keywords: d.rast.leg added
Milestone: 7.0.07.0.1

BTW: The changes broke d.rast.leg.

Fixed in trunk r65147 and relbranch70 r65148.

Note: See TracTickets for help on using tickets.