Opened 6 years ago

Closed 6 years ago

#2440 closed task (fixed)

remove unused elements from g.list/g.remove

Reported by: annakrat Owned by: grass-dev@…
Priority: blocker Milestone: 7.0.0
Component: LibGIS Version: svn-releasebranch70
Keywords: elements, g.remove Cc: martinl
CPU: Unspecified Platform: All

Description

Half of the elements in g.remove and related modules are not used any more. Let's remove them from GRASS7.

  • old (GRASS 5.0) vector map(s)
  • ASCII vector map(s)
  • paint icon file(s)
  • paint label file(s)
  • site list file(s)
  • 3D view parameter(s)

Please correct me if we still use some of them. Technically it's easy to remove them, just remove a couple of lines in lib/manage/element_list file.

Change History (17)

comment:1 in reply to:  description Changed 6 years ago by martinl

Replying to annakrat:

Half of the elements in g.remove and related modules are not used any more. Let's remove them from GRASS7.

agreed.

comment:2 Changed 6 years ago by annakrat

Hm, we still have v.in.sites and v.in.sites.all so I would suggest to remove them too, as well as the library (lib/sites). Does anyone know what's the status of 'paint label file'? There are modules v.label and d.labels so it seems that we should still support it. For the other elements I couldn't find any module which would be using them so they can be removed safely.

comment:3 in reply to:  2 Changed 6 years ago by neteler

Replying to annakrat:

Hm, we still have v.in.sites and v.in.sites.all so I would suggest to remove them too, as well as the library (lib/sites).

Yes

Does anyone know what's the status of 'paint label file'? There are modules v.label and d.labels so it seems that we should still support it.

(there is also v.label.sa lurking ...)

For the other elements I couldn't find any module which would be using them so they can be removed safely.

comment:4 Changed 6 years ago by annakrat

I removed sites element together with the library in r62179, then I removed paint icons in r62180 (I have no idea what it is and I haven't found any related library) and finally I removed 3dview element, but I kept the library itself, since it still might be useful I think. I would appreciate if someone else could have a look at the old vector formats, I have no idea what is the difference between them and which libraries they use. I think we don't need any of them in GRASS7.

comment:5 Changed 6 years ago by martinl

After some cleaning done with #2409 the list of elements is now

               raster: raster map(s)
               raster_3d: 3D raster map(s)
               vector: vector map(s)
               old_vector: old  (GRASS 5.0) vector map(s)
               ascii_vector: ASCII vector map(s)
               labels: paint label file(s)
               region: region definition(s)
               group: imagery group(s)
               all: all types

Is it OK to close this ticket or is there still any remaining issue?

comment:6 Changed 6 years ago by martinl

Cc: martinl added

comment:7 Changed 6 years ago by neteler

As of r63875 it is

               raster: raster map(s)
               raster_3d: 3D raster map(s)
               vector: vector map(s)
               ascii_vector: ASCII vector map(s)
               labels: paint label file(s)
               region: region definition(s)
               group: imagery group(s)
               all: all types

comment:8 Changed 6 years ago by annakrat

There is still the ascii_vector, I have no idea what it is.

comment:9 in reply to:  8 ; Changed 6 years ago by martinl

Priority: normalblocker

Replying to annakrat:

There is still the ascii_vector, I have no idea what it is.

I also don't know. Anyone has an idea? If not I would suggest to remove it too.

comment:10 in reply to:  9 ; Changed 6 years ago by neteler

Replying to martinl:

Replying to annakrat:

There is still the ascii_vector, I have no idea what it is.

I also don't know. Anyone has an idea? If not I would suggest to remove it too.

http://grass.osgeo.org/grass70/manuals/v.out.ascii.html

"If old version is requested, the output files from v.out.ascii is placed in the $LOCATION/$MAPSET/dig_ascii/ and $LOCATION/$MAPSET/dig_att directory."

So, it stems from GRASS GIS 4 and older. Random citation:

GRASS-Intergraph Data Conversion Guide by V Harmon - ‎1992, http://www.dtic.mil/get-tr-doc/pdf?AD=ADA251458 (p. 14)

Less used nowadays :-)

comment:11 in reply to:  10 ; Changed 6 years ago by martinl

http://grass.osgeo.org/grass70/manuals/v.out.ascii.html

"If old version is requested, the output files from v.out.ascii is placed in the $LOCATION/$MAPSET/dig_ascii/ and $LOCATION/$MAPSET/dig_att directory."

So, it stems from GRASS GIS 4 and older. Random citation:

GRASS-Intergraph Data Conversion Guide by V Harmon - ‎1992, http://www.dtic.mil/get-tr-doc/pdf?AD=ADA251458 (p. 14)

Less used nowadays :-)

if it's only one usage I would still to vote for removing it from element list. What do you think?

comment:12 in reply to:  11 ; Changed 6 years ago by martinl

Replying to martinl:

http://grass.osgeo.org/grass70/manuals/v.out.ascii.html

"If old version is requested, the output files from v.out.ascii is placed in the $LOCATION/$MAPSET/dig_ascii/ and $LOCATION/$MAPSET/dig_att directory."

So, it stems from GRASS GIS 4 and older. Random citation:

GRASS-Intergraph Data Conversion Guide by V Harmon - ‎1992, http://www.dtic.mil/get-tr-doc/pdf?AD=ADA251458 (p. 14)

Less used nowadays :-)

if it's only one usage I would still to vote for removing it from element list. What do you think?

any option?

comment:13 in reply to:  12 ; Changed 6 years ago by martinl

Replying to martinl:

if it's only one usage I would still to vote for removing it from element list. What do you think?

any option?

I removed ascii_vector in trunk as r64004. Any objection to backport to relbr70?

comment:14 in reply to:  13 ; Changed 6 years ago by martinl

Replying to martinl:

Replying to martinl:

if it's only one usage I would still to vote for removing it from element list. What do you think?

any option?

I removed ascii_vector in trunk as r64004. Any objection to backport to relbr70?

r64004:64005

comment:15 in reply to:  14 Changed 6 years ago by martinl

Replying to martinl:

I removed ascii_vector in trunk as r64004. Any objection to backport to relbr70?

r64004:64005

done in r64104

comment:16 Changed 6 years ago by martinl

Currently the element list looks like:

       type   Data type(s)
              options: raster,raster_3d,vector,label,region,group,all
               raster: raster map(s)
               raster_3d: 3D raster map(s)
               vector: vector map(s)
               label: paint label file(s)
               region: region definition(s)
               group: imagery group(s)
               all: all types

Is there any open issue?

comment:17 Changed 6 years ago by annakrat

Resolution: fixed
Status: newclosed

Thanks! I think we can close it. The actual code for handling different vector formats is still there, but from what I remember when I was looking at it, it would be quite time consuming to clean it up.

Note: See TracTickets for help on using tickets.