Opened 6 years ago

Closed 3 years ago

#2370 closed defect (fixed)

g.html2man.py fails while processing keyword list

Reported by: marisn Owned by: grass-dev@…
Priority: minor Milestone: 7.2.3
Component: Parser Version: svn-trunk
Keywords: HTML, documenation Cc:
CPU: Unspecified Platform: Unspecified

Description

GRASS trunk r61272

VERSION_NUMBER=7.1.svn /home/maris/soft/grass_trunk/dist.x86_64-unknown-linux-gnu/tools/g.html2man.py /home/maris/soft/grass_trunk/dist.x86_64-unknown-linux-gnu/docs/html/keywords.html /home/maris/soft/grass_trunk/dist.x86_64-unknown-linux-gnu/docs/man/man1/keywords.1
/home/maris/soft/grass_trunk/dist.x86_64-unknown-linux-gnu/docs/html/keywords.html:16:0: Error (IndexError('pop from empty list',)): <dt><b><h2>SYNOPSIS</h2></b></dt><dd> <a href="test.raster3d.lib.html">test.raster3d.lib</a></dd>

Change History (7)

comment:1 Changed 6 years ago by wenzeslaus

Component: PythonParser
Keywords: HTML documenation added
Priority: normalminor

This was fixed by r61274 done by Soeren. r61275 compiles now.

However, we may consider if this is in fact bug in GRASS parser or g.html2man.py. Perhaps, parser should not allow no keywords (checked in G_parser() or "--help" function and company) and/or g.html2man.py should provide better error message or work with an empty keywords list. The error message also suggests that output of --html-description is not a valid HTML (if there are no keywords) and if this is the case, this should be fixed in the first place.

comment:2 in reply to:  1 Changed 6 years ago by glynn

Replying to wenzeslaus:

However, we may consider if this is in fact bug in GRASS parser or g.html2man.py.

Or possibly in man/build_keywords.py.

That script appears to be trying to parse HTML using Python's generic string-processing functions, which is unlikely to be robust. Consider using tools/g.html2man/html.py.

comment:3 Changed 4 years ago by neteler

Milestone: 7.1.07.2.0

Milestone renamed

comment:4 Changed 4 years ago by neteler

Milestone: 7.2.07.2.1

Ticket retargeted after milestone closed

comment:5 Changed 3 years ago by martinl

Milestone: 7.2.17.2.2

comment:6 Changed 3 years ago by neteler

Milestone: 7.2.27.2.3

Ticket retargeted after milestone closed

comment:7 Changed 3 years ago by martinl

Resolution: fixed
Status: newclosed

Issue seems to be solved.

Note: See TracTickets for help on using tickets.