Opened 5 years ago

Closed 7 months ago

#2348 closed defect (fixed)

r.stream.order Error finding nodes.

Reported by: hcho Owned by: grass-dev@…
Priority: normal Milestone: 7.6.2
Component: Raster Version: svn-trunk
Keywords: r.stream.order Cc:
CPU: All Platform: All

Description

When a cell has five tributaries, ram_number_of_tribs (or seg_number_of_tribs) doesn't complain (trib > 5 in line 17), but ram_stream_topology raises a fatal error with the same counting logic (trib > 4 in line 89). I think 5 incoming tributaries, 1 outgoing and 2 non-stream cells should be fine here too.

IMHO, lines 89 and 308 should also be trib > 5 for consistency.

Change History (10)

comment:1 Changed 4 years ago by neteler

Milestone: 7.1.07.2.0

Milestone renamed

comment:2 Changed 3 years ago by neteler

Can you please try again? A series of fixes have been implemented in the past months.

comment:3 Changed 3 years ago by neteler

Milestone: 7.2.07.2.1

Ticket retargeted after milestone closed

comment:4 Changed 3 years ago by martinl

Milestone: 7.2.17.2.2

comment:5 Changed 2 years ago by neteler

Milestone: 7.2.27.2.3

Ticket retargeted after milestone closed

comment:6 in reply to:  description Changed 2 years ago by mmetz

Replying to hcho:

When a cell has five tributaries, ram_number_of_tribs (or seg_number_of_tribs) doesn't complain (trib > 5 in line 17), but ram_stream_topology raises a fatal error with the same counting logic (trib > 4 in line 89). I think 5 incoming tributaries, 1 outgoing and 2 non-stream cells should be fine here too.

IMHO, lines 89 and 308 should also be trib > 5 for consistency.

The max number of tributaries has been synced to be 5 in r71703.

comment:7 Changed 20 months ago by martinl

Milestone: 7.2.3

Ticket retargeted after milestone closed

comment:8 Changed 20 months ago by martinl

Milestone: 7.2.4

comment:9 Changed 7 months ago by martinl

Milestone: 7.2.47.6.2

comment:10 Changed 7 months ago by martinl

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.