Opened 10 years ago
Closed 10 years ago
#2342 closed defect (fixed)
G7: deprecate r.los in favour of r.viewshed
Reported by: | neteler | Owned by: | |
---|---|---|---|
Priority: | blocker | Milestone: | 7.0.0 |
Component: | Raster | Version: | svn-releasebranch70 |
Keywords: | r.los, r.viewshed | Cc: | |
CPU: | Unspecified | Platform: | All |
Description
Given the long term testing of r.viewshed, are there objections to remove r.los from GRASS 7?
Here some related discussion from grass-dev:
On Fri, Dec 2, 2011 at 6:44 AM, Hamish wrote:
Michael wrote:
How does r.viewshed differ from r.los?
basically it is faster and it scales to large regions well.
I don't know the exact O()ness level of it, but r.los becomes very quickly slower after the region size gets bigger than a smallish amount of rows x columns, to the point where it becomes unusable.
...
from the code header comments:
- The viewshed algorithm is efficient both in
- terms of CPU operations and I/O operations. It has worst-case
- complexity O(n lg n) in the RAM model and O(sort(n)) in the
- I/O-model. For the algorithm and all the other details see the
- paper: "Computing Visibility on * Terrains in External Memory" by
- Herman Haverkort, Laura Toma and Yi Zhuang.
Change History (7)
comment:1 by , 10 years ago
Priority: | normal → blocker |
---|
follow-up: 3 comment:2 by , 10 years ago
follow-up: 4 comment:3 by , 10 years ago
Replying to cmbarton:
To avoid confusion and duplication of modules, I'm in favor of replacing r.los with r.viewshed. Then maybe we can do a cumulative view shed routine in the near future.
+1 (r.los
can be moved to addons)
follow-up: 5 comment:4 by , 10 years ago
follow-up: 6 comment:5 by , 10 years ago
Replying to martinl:
Replying to martinl:
Replying to cmbarton:
To avoid confusion and duplication of modules, I'm in favor of replacing r.los with r.viewshed. Then maybe we can do a cumulative view shed routine in the near future.
+1 (
r.los
can be moved to addons)If no objections I will do it in the next few days.
I'm working on it now.
comment:7 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
To avoid confusion and duplication of modules, I'm in favor of replacing r.los with r.viewshed. Then maybe we can do a cumulative view shed routine in the near future.
Michael