Opened 10 years ago
Closed 10 years ago
#1981 closed defect (fixed)
export error in osgeo4w/grass.tmpl
|Reported by:||hamish||Owned by:|
unless I'm misreading something the "export" in osgeo4w/grass.tmpl is called incorrectly. (all branches)
export $OSGEO4W_ROOT_MSYS $GISBASE $GRASS_SH $GRASS_WISH $GRASS_PYTHON $PYTHONHOME $GRASS_PROJSHARE export $PATH
the $VARIABLES get exanded before the command is called, so the contents of the $VARIABLES get exported, not the variable names. i.e. when using "export" or "unset", don't add the "$".
also I suspect that in the lines above the enviro variable settings should be "quoted". (most will just be C:\osgeo4w so not a big deal, but for correctness/safety/future these things should be fixed..)
ok to change?
Change History (3)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
done in trunk and devbr6 with r56458,9.
another one to consider changing, in env.bat:
-set GRASS_PYTHON=python +set GRASS_PYTHON=%GISBASE%\extrabin\python.exe
comment:3 by , 10 years ago
|Status:||new → closed|
applied in relbr64 in r56631.
Replying to hamish:
Yes. A "$" in an "export" command is almost always wrong.
There might be a situation where "
export $LD_LIBRARY_PATH_VAR" is required, but I think that LD_LIBRARY_PATH_VAR is normally substituted rather than ending up in the final script.