Opened 7 years ago

Closed 3 years ago

#1966 closed defect (fixed)

filesystem cruft from wingrass installer

Reported by: hamish Owned by: grass-dev@…
Priority: trivial Milestone: 7.0.5
Component: Packaging Version: svn-trunk
Keywords: wingrass Cc:
CPU: All Platform: MSWindows XP

Description

Hi, noticed while fixing #1946, some wingrass installer cruft left behind in the file system:

  • install_msruntime dir from osgeo4w left over in ...\Local Settings\Temp\ (all versions of grass). Delete and RMDir commands in the nsis installer script don't catch it.
  • Makefile and grassrc.tmpl file have made it into $GISBASE/demolocation ? (grass7 only)

Hamish

Change History (5)

comment:1 in reply to:  description Changed 7 years ago by neteler

Replying to hamish:

  • Makefile and grassrc.tmpl file have made it into $GISBASE/demolocation ? (grass7 only)

See r39708 - Build demolocation using $(MKDIR) and $(INSTALL) instead of "tar"

comment:2 Changed 7 years ago by hamish

the wingrass installer isn't using 'make install', it simply does a recursive copy of src/demolocation/ from the svn checkout directory:

;Define the source path of the demolocation files

!define DEMOLOCATION_PATH "c:\OSGeo4W@OSGEO4W_DIR_POSTFIX@\usr\src\grass_trunk\demolocation"

...

        ;Install demolocation into the GIS_DATABASE directory
        SetOutPath "$GIS_DATABASE\demolocation"
        File /r ${DEMOLOCATION_PATH}\*.*

so as long as that is the case, probably an explicit delete like is done for .svn/ there is needed too.

Hamish

comment:3 Changed 4 years ago by martinl

Milestone: 7.0.07.0.5

comment:4 Changed 3 years ago by martinl

No activity last 3 years, closing, feel free to reopen if needed.

comment:5 Changed 3 years ago by neteler

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.