Opened 7 years ago

Closed 7 years ago

#1834 closed defect (fixed)

backport r47878 (set field width for string columns in v.out.ogr) to grass6 ?

Reported by: mlennert Owned by: grass-dev@…
Priority: normal Milestone: 6.4.3
Component: Vector Version: svn-releasebranch64
Keywords: Cc:
CPU: Unspecified Platform: Unspecified

Description

Is there any reason that r47878 couldn't be backported to grass6 ? If not then it would be a good idea to do so.

Moritz

Attachments (1)

v.out.ogr_fieldwith.diff (1.2 KB) - added by mlennert 7 years ago.
patch to allow export of varchar field width

Download all attachments as: .zip

Change History (4)

comment:1 Changed 7 years ago by neteler

The real change seem to be these two lines:

 	630	                 if (ogr_ftype == OFTString && colwidth > 0) 
 	631	                     OGR_Fld_SetWidth(Ogr_field, colwidth);

I cannot see anything dangerous here.

comment:2 in reply to:  1 Changed 7 years ago by mlennert

Replying to neteler:

The real change seem to be these two lines:

 	630	                 if (ogr_ftype == OFTString && colwidth > 0) 
 	631	                     OGR_Fld_SetWidth(Ogr_field, colwidth);

I cannot see anything dangerous here.

The attached patch seems to do the job for me. Potential candidate for bugfix in grass64 release, or is it too late ? I find this a quite annoying bug.

Moritz

Changed 7 years ago by mlennert

Attachment: v.out.ogr_fieldwith.diff added

patch to allow export of varchar field width

comment:3 Changed 7 years ago by neteler

Resolution: fixed
Status: newclosed

Committed in r55575 and r55576. Closing.

Note: See TracTickets for help on using tickets.