v.in.ogr: truncate cnames to first word

[hamish]

If you (ahem) don't read the instructions properly and with v.in.ogr's cnames= option provide column types with the new names it gets added into the vector's dbln file as an extra word, corrupting it. (it writes "cat integer" as the key column, but then after reads DB filename as the third word in the dbln file, which is "integer" not $GISDBASE/...)

then you can't do much (even remove the vector) without fixing the dbln file.

to protect against that...

v.in.ogr line 270:

    ncnames = 0;
    if ( cnames_opt->answers ) {
	i = 0;
	while ( cnames_opt->answers[i++] ) {
	    ncnames++;
	}
    }

in that loop add some sort of

strchrnul(cnames_opt->answers[i-1], ' ') = '\0';

to cut away all but the first word? how to write that correctly?

Hamish

[mmetz]

Replying to hamish:

If you (ahem) don't read the instructions properly and with v.in.ogr's cnames= option provide column types with the new names it gets added into the vector's dbln file as an extra word, corrupting it. (it writes "cat integer" as the key column, but then after reads DB filename as the third word in the dbln file, which is "integer" not $GISDBASE/...)

then you can't do much (even remove the vector) without fixing the dbln file.

to protect against that...

v.in.ogr line 270:

     ncnames = 0;
     if ( cnames_opt->answers ) {
 	i = 0;
 	while ( cnames_opt->answers[i++] ) {
 	    ncnames++;
 	}
     }

in that loop add some sort of

strchrnul(cnames_opt->answers[i-1], ' ') = '\0';

Fixed in trunk r52812 by adding G_strip() followed by G_strchg(). Works for me now. To be backported.

Markus M

[hamish]

Replying to mmetz:

Fixed in trunk r52812 by adding G_strip() followed by G_strchg(). Works for me now. To be backported.

[neteler]

Replying to hamish:

Replying to mmetz:

Fixed in trunk r52812 by adding G_strip() followed by G_strchg(). Works for me now. To be backported.

Backported in r56069 and r56070. Closing.