Opened 8 years ago

Closed 6 years ago

#1467 closed enhancement (fixed)

include/gis.h hard-coding version a the SVN revision level

Reported by: strk Owned by: grass-dev@…
Priority: minor Milestone: 6.4.4
Component: LibGIS Version: svn-develbranch6
Keywords: api Cc:
CPU: All Platform: All

Description

Setting GIS_H_VERSION to the SVN revision level and using that to check compatibility between clients and library means no two SVN revisions would be considered compatible. Is this intended ?

Attachments (1)

lib_compatibility_message.patch (1.1 KB) - added by neteler 6 years ago.
Patch updated to 6.4.svn r60058

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by strk

The attached patch makes the incompatibility error message more complete (and clearer to me).

comment:2 in reply to:  description Changed 8 years ago by glynn

Replying to strk:

Setting GIS_H_VERSION to the SVN revision level and using that to check compatibility between clients and library means no two SVN revisions would be considered compatible. Is this intended ?

Yes.

comment:3 in reply to:  1 ; Changed 8 years ago by neteler

Replying to strk:

The attached patch makes the incompatibility error message more complete (and clearer to me).

Indeed the current message (here, using spgrass6 in R):

GRASS GIS interface loaded with GRASS version: GRASS 6.4.2svn48651M (2011) 
and location: latlong
ERROR: Incompatible library version for module. You need to rebuild GRASS
       or untangle multiple installations.

is fairly unhelpful. No clue what to recompile since GRASS is working...

comment:4 Changed 7 years ago by hamish

Component: DefaultLibGIS
CPU: UnspecifiedAll
Keywords: api added
Milestone: 6.4.4
Platform: UnspecifiedAll
Priority: normalminor
Type: defectenhancement
Version: unspecifiedsvn-develbranch6

Changed 6 years ago by neteler

Patch updated to 6.4.svn r60058

comment:5 in reply to:  3 Changed 6 years ago by neteler

Replying to neteler:

Replying to strk:

The attached patch makes the incompatibility error message more complete (and clearer to me).

Indeed the current message (here, using spgrass6 in R):

GRASS GIS interface loaded with GRASS version: GRASS 6.4.2svn48651M (2011) 
and location: latlong
ERROR: Incompatible library version for module. You need to rebuild GRASS
       or untangle multiple installations.

is fairly unhelpful. No clue what to recompile since GRASS is working...

New message:

...
if [ "/home/neteler/software/grass71/dist.x86_64-unknown-linux-gnu/bin/v.perturb" != "" ] ; then GISRC=/home/neteler/software/grass71/dist.x86_64-unknown-linux-gnu/demolocation/.grassrc71 GISBASE=/home/neteler/software/grass71/dist.x86_64-unknown-linux-gnu PATH="/home/neteler/software/grass71/dist.x86_64-unknown-linux-gnu/bin:/home/neteler/software/grass71/dist.x86_64-unknown-linux-gnu/bin:/home/neteler/software/grass71/dist.x86_64-unknown-linux-gnu/scripts:$PATH" PYTHONPATH="/home/neteler/software/grass71/dist.x86_64-unknown-linux-gnu/etc/python:/home/neteler/software/grass71/dist.x86_64-unknown-linux-gnu/gui/wxpython:$PYTHONPATH" LD_LIBRARY_PATH="/home/neteler/software/grass71/dist.x86_64-unknown-linux-gnu/bin:/home/neteler/software/grass71/dist.x86_64-unknown-linux-gnu/scripts:/home/neteler/software/grass71/dist.x86_64-unknown-linux-gnu/lib:/home/neteler/software/grass71/dist.x86_64-unknown-linux-gnu/lib:" LC_ALL=C /home/neteler/software/grass71/dist.x86_64-unknown-linux-gnu/bin/v.perturb --html-description < /dev/null | grep -v '</body>\|</html>' > v.perturb.tmp.html ; fi
ERROR: Module built against version $Revision: 59317 $ trying to use
       version $Revision: 60123 $.You need to rebuild GRASS GIS or untangle
       multiple installations.
make[3]: *** [v.patch.tmp.html] Error 1
rm v.patch.tmp.html
make[3]: Leaving directory `/home/neteler/software/grass71/vector/v.patch'

Patch applied to trunk in r60135.

Backport desired (perhaps with improved wording).

comment:6 Changed 6 years ago by strk

Sounds good to me, thanks.

comment:7 Changed 6 years ago by neteler

Resolution: fixed
Status: newclosed

Backported to relbr7 (r60193), devlbr6 (r60194) and relbr6 (r60195).

Thanks for the patch & closing.

Note: See TracTickets for help on using tickets.