Opened 11 years ago

Closed 11 years ago

#1398 closed defect (fixed)

problem with multiple entry selection

Reported by: cmbarton Owned by: martinl
Priority: normal Milestone: 6.4.2
Component: wxGUI Version: 6.4.1 RCs
Keywords: multiple entries, multiple selections Cc: grass-dev@…
CPU: All Platform: All

Description

For commands that allow for multiple entry selections, the entry cannot be edited in the gui dialog. Example: For a command like r.report, select map1, map2, map3 and press run. Then delete map1 and map2 from the list in the map selection control. Press run and r.report is run on map1, map2, and map3 again.

In gselect.py, when multiple=True, all selections are stored to a list. New selections are appended to that list. But the list is not updated with values actually in the control. So any edits to the list of maps (or other items) is not recognized. I think this is happening in line 493, but I can't find a way to update the list of multiple values (self.value) with the items that are actually in the control.

Change History (6)

comment:1 by cmbarton, 11 years ago

Maybe I found it.

I think you need to insert

self.value = self.GetCombo().GetValue().split(',')

before line 236 in gselect.py.

I can't commit this tonight, but if someone wants to check and let me know if this solves the problem for them too, I can do so tomorrow.

Michael

comment:2 by martinl, 11 years ago

Milestone: 6.4.2

comment:3 by cmbarton, 11 years ago

This should be fixed now in all versions. Can anyone else give it a test so we can close this?

Michael

in reply to:  3 comment:4 by martinl, 11 years ago

Cc: grass-dev@… added
Owner: changed from grass-dev@… to martinl
Status: newassigned

Replying to cmbarton:

This should be fixed now in all versions. Can anyone else give it a test so we can close this?

Not really it introduced extra comma before first selected map. Hopefully fixed in r48264.

comment:5 by cmbarton, 11 years ago

I just tested and it seems to be fixed.

Michael

comment:6 by martinl, 11 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.