configure fails to detect X11 on OS X

[snorfalorpagus]

Configure was refusing to detect X11, despite specification of --with-x, --x-libraries and --x-includes. This is due to OS X using a different shared library suffix (*.dylib) to other OSs, which was missed out of the search path. Applies to 6.4, 6.5 and 7. Patch attached (for 6.5).

[snorfalorpagus]

cd grass6_devel; patch < dylib.patch

[glynn]

Replying to snorfalorpagus:

Patch attached (for 6.5).

There's no point patching the configure script; it's generated by autoconf from configure.in and aclocal.m4, so any changes will be lost the next time that the source files are updated (unless we remember to keep patching it, which is unlikely to happen).

The X stuff is handled by autoconf's AC_PATH_XTRA macro, which uses AC_PATH_X_XMKMF, which doesn't recognise the .dylib suffix. At least, the version from 2.13 doesn't. Updating to a later version of autoconf is probably worthwhile, but it's potentially a lot of work.

In the meantime, it might be possible to override AC_PATH_X_XMKMF with a fixed local version.

[kyngchaos]

I don't have a problem detecting X11. I've always specified --with-x, --x-includes and --x-libraries. If you use --x-includes and --x-libraries, configure never gets to the parts to check for the existence of library files (where your patches apply), it just assumes you're right.

if test "x$with_x" = xno; then
  # The user explicitly disabled X.
  have_x=disabled
else
  if test "x$x_includes" != xNONE && test "x$x_libraries" != xNONE; then
    # Both variables are already set.
    have_x=yes
  else
# check for libs and includes...
  fi
fi

[hamish]

any update?