Opened 12 years ago

Closed 11 years ago

#1352 closed defect (fixed)

Mismatch between overwrite parameter in GCPManager and v.transform

Reported by: rangoy Owned by: martinl
Priority: minor Milestone: 6.4.2
Component: wxGUI Version: svn-releasebranch64
Keywords: georectify Cc: grass-dev@…
CPU: Unspecified Platform: Unspecified

Description

It appears that commit [45931] introduces a mismatch in the overwrite parameter in grass/branches/releasebranch_6_4/gui/wxpython/gui_modules/gcpmanager.py (arround line 1395-1396)

v.transform still wants the overwrite flag to be written as "--o", but this changeset removes one of the "-"s.

I don't know which of the modules are wrong, but I fixed it temporarily by applying this patch;

Index: gui/wxpython/gui_modules/gcpmanager.py
===================================================================
--- gui/wxpython/gui_modules/gcpmanager.py	(revisjon 46106)
+++ gui/wxpython/gui_modules/gcpmanager.py	(arbeidskopi)
@@ -1392,7 +1392,7 @@
                 msg = err = ''
 
                 ret, out, err = gcmd.RunCommand('v.transform',
-                                                flags = 'o',
+                                                flags = '-o',
                                                 input = vect,
                                                 output = self.outname,
                                                 pointsfile = self.file['points'],

Change History (3)

comment:1 by martinl, 12 years ago

Cc: grass-dev@… added
Component: DefaultwxGUI
Keywords: georectify added
Milestone: 6.4.2
Owner: changed from grass-dev@… to martinl
Status: newassigned

Hopefully fixed in r46107. Instead of flags = '-o' use overwrite = True.

in reply to:  description comment:2 by glynn, 12 years ago

Replying to rangoy:

v.transform still wants the overwrite flag to be written as "--o", but this changeset removes one of the "-"s.

I don't know which of the modules are wrong, but I fixed it temporarily by applying this patch;

The patch is incorrect; the flags= parameter should never contain a dash. The patch only works as a side-effect of the naive way in which the flags= parameter is currently handled.

The correct way to enable overwrite is to pass "overwrite = True".

comment:3 by martinl, 11 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.