Opened 11 years ago
Closed 10 years ago
#58 closed defect (wontfix)
Incorrect Makefile.am variable usage
| Reported by: | dmacks | Owned by: | warmerdam |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | libgeotiff | Version: | 1.3.0 |
| Keywords: | Cc: |
Description
change #1684 is not correct. AM_CFLAGS is for flags destined to both the source-compiler (.c -> .o stage) and the linker (.o -> lib or program), but -I flags are only for the source-compiler stage.
More important, it's also functionally broken: foo_CPPFLAGS gets passed fairly early in the list of flags to the compiler whereas foo_CFLAGS is much later, notably, *after* CPPFLAGS that comes from the shell env variable. If foo_CFLAGS, which contains -I flags to the source-distro, is after CPPFLAGS, which can contain global (system installed) -I flags, the compiler will see already-installed .h in preference to local source ones. If I have random .h from some other package (or a different version of libgeotiff) installed, they can mask the ones in the libgeotiff tarball and lead to compile failure or incorrect build results.
Change History (2)
comment:1 by , 10 years ago
comment:2 by , 10 years ago
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
It sounds like you know how this issue should be fixed, but your not does not make a prescription as to what to do. Do you have a change that you would like to see made here? I'm happy to accommodate, but I'm not going to go wading into the automake swamp to fix this on my own.