Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#46 closed defect (fixed)

Invalid csv filenames in Makefile.am

Reported by: gadomski Owned by: warmerdam
Priority: normal Milestone:
Component: libgeotiff Version: 1.3.0
Keywords: csv typo Cc:

Description

In source:Makefile.am, source:csv/compdcs.csv, does not exist in the repo, and cvs/deprecation.csv should be source:csv/deprecation.csv.

Attachments (1)

46-makefile-fixes.diff​ (732 bytes ) - added by gadomski 13 years ago.
Diff describing changes to Makefile.am that allows compilation

Download all attachments as: .zip

Change History (8)

by gadomski, 13 years ago

Attachment: 46-makefile-fixes.diff​ added

Diff describing changes to Makefile.am that allows compilation

comment:1 by hobu, 13 years ago

applied in r2105. please confirm.

comment:2 by hobu, 13 years ago

I only fixed the cvs->csv typo, in my patch. I did not touch the compd.csv issue.

comment:3 by warmerdam, 13 years ago

I think the fix is to actually add compd.csv in svn rather than commenting it out of Makefile.am. I would like to consider that this evening.

in reply to:  1 comment:4 by gadomski, 13 years ago

Replying to hobu:

applied in r2105. please confirm.

I can confirm that the typo is fixed. Fresh checkout is still broken w/o compd.csv, see comment:3.

comment:5 by warmerdam, 13 years ago

Resolution: → fixed
Status: new → closed

Additional fixes for csv files (r2106) and Makefile.am (r2107). I have confirmed that "make dist" now works.

comment:6 by hobu, 13 years ago

cmake config updated in r2108

Note: See TracTickets for help on using tickets.