Opened 5 years ago

Closed 5 years ago

#966 closed defect (duplicate)

CMake does not build/test doc/example.cpp

Reported by: dbaston Owned by: geos-devel@…
Priority: major Milestone: 3.8.0
Component: Build/Install (cmake) Version: main
Severity: Unassigned Keywords:
Cc:

Description


Change History (4)

comment:1 by strk, 5 years ago

Doesn't really need to... Does autotools do ? I guess it's enough that "make check" builds it, as it's just a build test, basically (and nobody should use the C++ interface anyway, would be about time to have an example.c)

comment:2 by dbaston, 5 years ago

I just noticed it because Travis showed a build failure with autotools, which builds example.cpp, but not with CMake. I don't have an opinion on whether we provide an example.cpp, but if do provide one we ought to at least test that it compiles and runs.

comment:3 by strk, 5 years ago

Agreed about testing it compiles (and sure, why not also run!). But has to be done on "make check", to not waste time on "make" (it's not meant to be a default target)

comment:4 by dbaston, 5 years ago

Resolution: duplicate
Status: newclosed

Duplicate of #901

Note: See TracTickets for help on using tickets.