Opened 6 years ago
Closed 5 years ago
#925 closed task (fixed)
No need of platform.h
Reported by: | cvvergara | Owned by: | cvvergara |
---|---|---|---|
Priority: | minor | Milestone: | 3.8.0 |
Component: | Core | Version: | 3.6.2 |
Severity: | Unassigned | Keywords: | C++11 |
Cc: |
Description
Due to the fact that on C++11
isnan
& isfinite
are part of the standard, there is no need to use platform.h dependency on the build.
tasks:
- change all the upper case that are around the code:
- ISNAN, IS FINITE to std::isnan std::isfinite respectively
- Some other definitions on platform.h can be change to be constant expressions instead of
#define
(in constants.h) - Remove the
#define define M_PI 3.14159265358979323846
that are around the code and include the constants.h - Delete the files platform.h
- Remove references on the build (cmake & autotools) about platform.h
Note:
See TracTickets
for help on using tickets.
In a582d47/git: