Opened 6 years ago

Closed 6 years ago

#920 closed defect (fixed)

.editorconfig not included in tar ball

Reported by: robe Owned by: geos-devel@…
Priority: blocker Milestone: 3.7.0
Component: Build/Install (cmake) Version: main
Severity: Unassigned Keywords:
Cc: jmckenna

Description

The .editorconfig was not include in tar ball and as a result made CMake fail in VS

.editorconfig

See:

https://lists.osgeo.org/pipermail/geos-devel/2018-August/008476.html

That was it, manually copying the missing file from svn or git, into the 
release package (geos-3.7.0rc1.tar.bz2) allows GEOS to compile with msvc 
2017.

-jeff




On 2018-08-23 2:21 PM, Jeff McKenna wrote:
> nor does the beta2 package.
> 
> I am assuming this file is stored in .git
> 
> -jeff
> 
> 
> 
> On 2018-08-23 2:20 PM, Jeff McKenna wrote:
>> Note that the RC1 package does not include a file named 
>> ".editorconfig", not does beta2 release.    -jeff
>>
>>
>>
>> On 2018-08-23 2:05 PM, Jeff McKenna wrote:
>>> It seems to be a problem in locating the file ".editorconfig" in 
>>> CMakeLists.txt on line #332.   Here is the log file: 
>>> https://pastebin.com/7VBkcpG3
>>>
>>> -jeff
>>>
>>>
>>>
>>> On 2018-08-23 1:47 PM, Regina Obe wrote:
>>>>> -- CMake 3.12.1 successfully configured GEOS using Visual Studio 15 
>>>>> 2017
>>>>> generator
>>>>> -- Configuring incomplete, errors occurred!
>>>>> See also
>>>>> "D:/build/mapserver-buildkit-2017/geos-
>>>>> 3.7.0rc1/build/CMakeFiles/CMakeOutput.log".
>>>>> See also
>>>>> "D:/build/mapserver-buildkit-2017/geos-
>>>>> 3.7.0rc1/build/CMakeFiles/CMakeError.log".
>>>>>
>>>>>
>>>>>
>>>>> -jeff
>>>>>
>>>>>
>>>> [Regina Obe]
>>>> What's the output of your CMakeError.log say?
>>>>
>>>> Thanks,
>>>> Regina
>>>>

Change History (3)

comment:1 by Regina Obe <lr@…>, 6 years ago

In 4f0f3f6/git:

Add .editorconfig to distribution, references #920 for geos 3.7.0

comment:2 by jmckenna, 6 years ago

Cc: jmckenna added

comment:3 by Regina Obe <lr@…>, 6 years ago

Resolution: fixed
Status: newclosed

In 35704ed1/git:

Add .editorconfig to distribution, closes #920 for geos 3.8.0

Note: See TracTickets for help on using tickets.