memory leak in GeometryCollection::getCoordinate()

[basiliscos]

The implementation is

const Coordinate*
GeometryCollection::getCoordinate() const
{
        // should use auto_ptr here or return NULL or throw an exception !
        //      --strk;
        if (isEmpty()) return new Coordinate();
        return (*geometries)[0]->getCoordinate();
}

So, if a collection is empty it returns coordinate and (to prevent memory leaks) assumes that caller should delete it. Otherwise it returns non-owning Coordinate* and not delete is required from caller.

The best way is return NULL as it is told in the comment.

The alternative will be

...
static Coordinate zero;
if (isEmpty()) return &zero;

[Daniel Baston <dbaston@…>]

In d1556af/git:

Fix memory leak on GeometryCollection::getCoordinate

Add tests to ensure all Geometry types have the same behavior when
calling getCoordinate on an empty geometry.

Fixes #918