mingw64 gcc 8.1 autotools

[robe]

So I upgraded my mingw64 to gcc 8.1 posix threads - seh

I think I'm actually getting further with compile under autotools now. Before it would break on configure (so I gave up on autotools and switched to cmake).

Now autotools seems to be getting further but failing here.

I'll submit my issue with cmake in a separate ticket.

make[4]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/unit'
make  check-TESTS
make[4]: Entering directory '/projects/geos/geos-3.7.0beta2/tests/unit'
make[5]: Entering directory '/projects/geos/geos-3.7.0beta2/tests/unit'
PASS: geos_unit.exe
============================================================================
Testsuite summary for
============================================================================
# TOTAL: 1
# PASS:  1
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================
make[5]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/unit'
make[4]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/unit'
make[3]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/unit'
Making check in perf
make[3]: Entering directory '/projects/geos/geos-3.7.0beta2/tests/perf'
Making check in operation
make[4]: Entering directory '/projects/geos/geos-3.7.0beta2/tests/perf/operation'
Making check in buffer
make[5]: Entering directory '/projects/geos/geos-3.7.0beta2/tests/perf/operation/buffer'
make[5]: Nothing to be done for 'check'.
make[5]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/perf/operation/buffer'
Making check in predicate
make[5]: Entering directory '/projects/geos/geos-3.7.0beta2/tests/perf/operation/predicate'
make[5]: Nothing to be done for 'check'.
make[5]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/perf/operation/predicate'
make[5]: Entering directory '/projects/geos/geos-3.7.0beta2/tests/perf/operation'
make[5]: Nothing to be done for 'check-am'.
make[5]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/perf/operation'
make[4]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/perf/operation'
Making check in capi
make[4]: Entering directory '/projects/geos/geos-3.7.0beta2/tests/perf/capi'
make  memleak_mp_prep.exe
make[5]: Entering directory '/projects/geos/geos-3.7.0beta2/tests/perf/capi'
x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I../../../include -I../../../include/geos  -I../../../capi -I../../../include  -Wsuggest-override -pedantic -Wall -Wno-long-long  -ffloat-store -DUSE_UNSTABLE_GEOS_CPP_API -g -O2 -MT memleak_mp_prep.o -MD -MP -MF .deps/memleak_mp_prep.Tpo -c -o memleak_mp_prep.o memleak_mp_prep.c
cc1.exe: warning: command line option '-Wsuggest-override' is valid for C++/ObjC++ but not for C
mv -f .deps/memleak_mp_prep.Tpo .deps/memleak_mp_prep.Po
/bin/sh ../../../libtool  --tag=CC   --mode=link x86_64-w64-mingw32-gcc -Wsuggest-override -pedantic -Wall -Wno-long-long  -ffloat-store -DUSE_UNSTABLE_GEOS_CPP_API -g -O2   -o memleak_mp_prep.exe memleak_mp_prep.o ../../../capi/libgeos_c.la ../../../capi/libgeos_c.la
libtool: link: x86_64-w64-mingw32-gcc -Wsuggest-override -pedantic -Wall -Wno-long-long -ffloat-store -DUSE_UNSTABLE_GEOS_CPP_API -g -O2 -o .libs/memleak_mp_prep.exe memleak_mp_prep.o  ../../../capi/.libs/libgeos_c.dll.a /projects/geos/geos-3.7.0beta2/src/.libs/libgeos.dll.a -L/projects/geos/rel-3.7.0beta2w64gcc48/lib
make[5]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/perf/capi'
make[4]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/perf/capi'
make[4]: Entering directory '/projects/geos/geos-3.7.0beta2/tests/perf'
make[4]: Nothing to be done for 'check-am'.
make[4]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/perf'
make[3]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/perf'
Making check in geostest
make[3]: Entering directory '/projects/geos/geos-3.7.0beta2/tests/geostest'
make  geostest.exe
make[4]: Entering directory '/projects/geos/geos-3.7.0beta2/tests/geostest'
x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I../../include -I../../include/geos  -I../../include -I../../tests/unit/tut -I../../capi  -Wsuggest-override -pedantic -Wall -Wno-long-long  -ffloat-store -DUSE_UNSTABLE_GEOS_CPP_API -g -O2 -MT geostest.o -MD -MP -MF .deps/geostest.Tpo -c -o geostest.o geostest.c
cc1.exe: warning: command line option '-Wsuggest-override' is valid for C++/ObjC++ but not for C
mv -f .deps/geostest.Tpo .deps/geostest.Po
/bin/sh ../../libtool  --tag=CC   --mode=link x86_64-w64-mingw32-gcc -Wsuggest-override -pedantic -Wall -Wno-long-long  -ffloat-store -DUSE_UNSTABLE_GEOS_CPP_API -g -O2   -o geostest.exe geostest.o ../../capi/libgeos_c.la -lstdc++
libtool: link: x86_64-w64-mingw32-gcc -Wsuggest-override -pedantic -Wall -Wno-long-long -ffloat-store -DUSE_UNSTABLE_GEOS_CPP_API -g -O2 -o .libs/geostest.exe geostest.o  ../../capi/.libs/libgeos_c.dll.a /projects/geos/geos-3.7.0beta2/src/.libs/libgeos.dll.a -lstdc++ -L/projects/geos/rel-3.7.0beta2w64gcc48/lib
make[4]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/geostest'
make[3]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/geostest'
Making check in thread
make[3]: Entering directory '/projects/geos/geos-3.7.0beta2/tests/thread'
make  threadtest.exe badthreadtest.exe
make[4]: Entering directory '/projects/geos/geos-3.7.0beta2/tests/thread'
x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -I. -I../../include -I../../include/geos  -I../../include -I../../tests/unit/tut -I../../capi  -Wsuggest-override -pedantic -Wall -Wno-long-long  -ffloat-store -DUSE_UNSTABLE_GEOS_CPP_API -g -O2 -MT threadtest.o -MD -MP -MF .deps/threadtest.Tpo -c -o threadtest.o threadtest.c
cc1.exe: warning: command line option '-Wsuggest-override' is valid for C++/ObjC++ but not for C
In file included from C:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/unistd.h:10,
                 from threadtest.c:19:
../../include/geos/io.h:19:1: error: unknown type name 'namespace'
 namespace geos {
 ^~~~~~~~~
../../include/geos/io.h:19:16: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
 namespace geos {
                ^
In file included from ../../include/geos/io.h:48,
                 from C:/ming64gcc48/mingw64/x86_64-w64-mingw32/include/unistd.h:10,
                 from threadtest.c:19:
../../include/geos/io/ByteOrderDataInStream.h:30:10: fatal error: iosfwd: No such file or directory
 #include <iosfwd> // ostream, istream (if we remove inlines)
          ^~~~~~~~
compilation terminated.
Makefile:443: recipe for target 'threadtest.o' failed
make[4]: *** [threadtest.o] Error 1
make[4]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/thread'
Makefile:555: recipe for target 'check-am' failed
make[3]: *** [check-am] Error 2
make[3]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests/thread'
Makefile:429: recipe for target 'check-recursive' failed
make[2]: *** [check-recursive] Error 1
make[2]: Leaving directory '/projects/geos/geos-3.7.0beta2/tests'
Makefile:480: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory '/projects/geos/geos-3.7.0beta2'
Makefile:776: recipe for target 'check' failed
make: *** [check] Error 2

[gdt]

It looks like a C++ file is being compiled with the C compiler (gcc, not g++).

[robe]

This problem got fixed as a result of changes done in past 2 weeks. Not sure what fixed it but -- yeh I can compile and regress fine again using autotools with mingw64 + gcc 8.1.0

[strk]

Great news. What else needs CMake then ? :)

[robe]

Everything