MCIndexSnapRounder::computeNodes holds dangling reference ( => SEGFAULT)

[basiliscos]

The MCIndexPointSnapper contains reference to index::SpatialIndex.

MCIndexPointSnapper {
public:
    MCIndexPointSnapper(index::SpatialIndex& nIndex): index(nIndex) {}
private:
        index::SpatialIndex& index;
}

In MCIndexSnapRounder::computeNodes it creates noder object on stack, and keeps the reference to SpatialIndex from the noder in the member variable pointSnapper . After exiting the method, the noder becomes destroyed and the reference becomes dandgling (lon longer pointing to valid object).

MCIndexSnapRounder::computeNodes(SegmentString::NonConstVect* inputSegmentStrings)
{
        nodedSegStrings = inputSegmentStrings;
        MCIndexNoder noder;
        pointSnapper.release(); // let it leak ?!
        pointSnapper.reset(new MCIndexPointSnapper(noder.getIndex()));
}

The folloing MCIndexSnapRounder::computeVertexSnaps invocation leads to SEGFAULT, as pointSnapper has dangling pointer.

MCIndexSnapRounder::computeVertexSnaps(NodedSegmentString* e)
{
        CoordinateSequence& pts0 = *(e->getCoordinates());
        for (unsigned int i=0, n=pts0.size()-1; i<n; ++i)
        {
                HotPixel hotPixel(pts0[i], scaleFactor, li);
                bool isNodeAdded = pointSnapper->snap(hotPixel, e, i);
        }
}

Please, fix.

[pramsey]

This ticket describes what (to me) looks like a valid problem, but it's quite a few releases old, and oddly there's no internal use of these classes (because they were kind of broken so they got worked around). I'm going to close it and recommend upgrading to 3.9