types inconsistency

[cvvergara]

• geos has int, unsigned int, and size_t as return type of the size() of geometry objects
• Also, the ith array element is the "index" and sometimes the index was int, unsigned int, or size_t

Some time ago a "static_cast" was added in order to have the compiler not complain like on the problems mentioned above:

conversion to ‘int’ from ‘std::vector<geos::index::sweepline::SweepLineEvent*>::size_type
{aka long unsigned int}’
may alter its value [-Wconversion]

Unifying all "index" and "size" types to size_t will:

• make the size type consistent with std type used for size()
• make the "index" type to a geometry be consistent across all geometries
• make the "static_cast" usage redundant, so it can be removed

[cvvergara]

This branch does makes the types consistent ​https://github.com/libgeos/geos/compare/master...cvvergara:rm-static-1

and travis execution is found here: ​https://travis-ci.org/cvvergara/geos/builds/404504153

[cvvergara]

related to #852

[cvvergara <vicky@…>]

In 7d577f9/git:

Closes #897 Unifying with size_t type

This is a combination of 23 commits.

[goatbar]

std::size_t please. ​https://en.cppreference.com/w/cpp/types/size_t

SimpleSweepLineIntersector.h:84:23: error: unknown type name 'size_t'; did you mean 'gnu_cxx::size_t'?