Opened 6 years ago

Closed 6 years ago

#888 closed defect (fixed)

Fix check-local failure when quilt patches are applied

Reported by: Bas Couwenberg Owned by: geos-devel@…
Priority: major Milestone: 3.7.0
Component: Default Version: 3.6.2
Severity: Unassigned Keywords:
Cc:

Description

The check-local target failed because it has the spelling error quilt patch applied:

make  check-local
make[5]: Entering directory '/build/geos-3.7.0~alpha'
! find . -name '*.cpp' -o -name '*.h' | \
        grep -v ^./tests/xmltester/tinyxml | \
        xargs grep -n '[[:space:]]$'
./.pc/spelling-errors.patch/tests/xmltester/tinyxml/tinyxml.h:83:#endif
./.pc/spelling-errors.patch/tests/xmltester/tinyxml/tinyxml.h:98:/*     Internal structure for tracking location of items
...
./.pc/spelling-errors.patch/tests/xmltester/tinyxml/tinyxml.h:1764:     /** Switch over to "stream printing" which is the most dense formatting without
./.pc/spelling-errors.patch/tests/xmltester/tinyxml/tinyxml.h:1769:                                                                                                     }
make[5]: *** [Makefile:931: check-local] Error 1
make[5]: Leaving directory '/build/geos-3.7.0~alpha'

The attached patch fixes the issue by using a less strict pattern to exclude.

Attachments (1)

check-local.patch (1.2 KB ) - added by Bas Couwenberg 6 years ago.

Download all attachments as: .zip

Change History (2)

by Bas Couwenberg, 6 years ago

Attachment: check-local.patch added

comment:1 by Sandro Santilli <strk@…>, 6 years ago

Resolution: fixed
Status: newclosed

In 9eb8152/git:

Better skip external sources from checking blanks

Patch by Bas Couwenberg
Closes #888

Note: See TracTickets for help on using tickets.