Opened 5 years ago
Closed 5 years ago
#854 closed defect (fixed)
Commits in pull requests can modify trac tickets
| Reported by: | strk | Owned by: | strk |
|---|---|---|---|
| Priority: | major | Milestone: | |
| Component: | Default | Version: | |
| Severity: | Unassigned | Keywords: | |
| Cc: |
Description
I just found out that a commit in a pull request can change a trac ticket, see https://trac.osgeo.org/geos/ticket/838#comment:5
This must be due to our post-update hook being fired also when pull requests are created (each pull request creates a reference in the base repository, under "ref/pull/x") - we should update the git hook to not consider ref/pull refs.
Change History (1)
comment:1 by , 5 years ago
| Milestone: | GEOS Future |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
| Version: | 3.6.2 |
Note:
See TracTickets
for help on using tickets.
Should be fixed with https://git.osgeo.org/gitea/geos/geos-git-hooks/commit/58b752c2a07eaadf2a13c4684cccfeeb85738077 (requires authentication and authorization to read)