Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#812 closed defect (fixed)

Fix overloaded virtual print in DirectedEdge*

Reported by: goatbar Owned by: strk
Priority: major Milestone: 3.6.1
Component: Core Version: 3.6.0
Severity: Unassigned Keywords: cleanup warnings
Cc:

Description

I would appreciate a review of this pull request:

​https://github.com/libgeos/libgeos/pull/78

  • Make print() method of child classes also const
  • Make getDepthDelta() const
  • Add virtual. For C++11 and newer this eventually should be overload.

e.g. 

geos::geomgraph::DirectedEdge::print' hides overloaded virtual function [-Woverloaded-virtual]

Pretty minor changes like this in include/geos/geomgraph/DirectedEdge.h, but it's helpful if things compile as cleanly as possible so I can catch other issues more easily. 

-       std::string print();
+       virtual std::string print() const;

Change History (5)

comment:1 by strk, 7 years ago

Resolution: → fixed
Status: new → closed

In 4336:

Fix overloaded virtual print in DirectedEdge*.

  • Make print() method of child classes also const
  • Make getDepthDelta() const
  • Add virtual. For C++11 and newer this eventually should be overload.

e.g.
geos::geomgraph::DirectedEdge::print' hides overloaded virtual function [-Woverloaded-virtual]

Patch by Kurt Schwehr <schwehr@…>
Fixes #812 in trunk (3.7.0)

comment:2 by strk, 7 years ago

In 4337:

Fix overloaded virtual print in DirectedEdge*.

  • Make print() method of child classes also const
  • Make getDepthDelta() const
  • Add virtual. For C++11 and newer this eventually should be overload.

e.g.
geos::geomgraph::DirectedEdge::print' hides overloaded virtual function [-Woverloaded-virtual]

Patch by Kurt Schwehr <schwehr@…>
Closes #812 in 3.6 branch (for 3.6.2)

comment:3 by Sandro Santilli <strk@…>, 7 years ago

In 6bb7b34/git:

Fix overloaded virtual print in DirectedEdge*.

  • Make print() method of child classes also const
  • Make getDepthDelta() const
  • Add virtual. For C++11 and newer this eventually should be overload.

e.g.
geos::geomgraph::DirectedEdge::print' hides overloaded virtual function [-Woverloaded-virtual]

Patch by Kurt Schwehr <schwehr@…>
Fixes #812 in trunk (3.7.0)

git-svn-id: ​http://svn.osgeo.org/geos/trunk@4336 5242fede-7e19-0410-aef8-94bd7d2200fb

comment:4 by Sandro Santilli <strk@…>, 7 years ago

In 6bb7b34/git:

Fix overloaded virtual print in DirectedEdge*.

  • Make print() method of child classes also const
  • Make getDepthDelta() const
  • Add virtual. For C++11 and newer this eventually should be overload.

e.g.
geos::geomgraph::DirectedEdge::print' hides overloaded virtual function [-Woverloaded-virtual]

Patch by Kurt Schwehr <schwehr@…>
Fixes #812 in trunk (3.7.0)

git-svn-id: ​http://svn.osgeo.org/geos/trunk@4336 5242fede-7e19-0410-aef8-94bd7d2200fb

comment:5 by Sandro Santilli <strk@…>, 7 years ago

In 6bb7b34/git:

Fix overloaded virtual print in DirectedEdge*.

  • Make print() method of child classes also const
  • Make getDepthDelta() const
  • Add virtual. For C++11 and newer this eventually should be overload.

e.g.
geos::geomgraph::DirectedEdge::print' hides overloaded virtual function [-Woverloaded-virtual]

Patch by Kurt Schwehr <schwehr@…>
Fixes #812 in trunk (3.7.0)

git-svn-id: ​http://svn.osgeo.org/geos/trunk@4336 5242fede-7e19-0410-aef8-94bd7d2200fb

Note: See TracTickets for help on using tickets.