GEOSSTRtree_nearest_r implementation missing from CAPI

[darkpanda]

It looks like the implementation for GEOSSTRtree_nearest_r is missing from the CAPI. The declaration exists in geos_c.h.in but there's no matching implementation.

[strk]

The function was added via ​https://github.com/libgeos/libgeos/pull/61 as per #768 Daniel: can you take a look at this ?

BTW: we really need to put the reentrant API under unit testing !

[strk]

Dane, please also implement GEOSSTRtree_nearest as a wrapper, for consistency and testsuite coverage (just realized that all re-entrant functions are already tested as a consequence of all non-reentrant ones being wrappers to the former)

[dbaston]

It already is a wrapper:

const GEOSGeometry *
GEOSSTRtree_nearest (geos::index::strtree::STRtree *tree,
                     const geos::geom::Geometry *g)
{
    return (const GEOSGeometry*) GEOSSTRtree_nearest_generic( tree, g, g, NULL, NULL);
}

[strk]

Must be a wrapper to the corresponding re-entrant interface, or it would never be tested. I tried locally and revealed a signature mismatch:

geos_c.cpp:1183:33: error: invalid conversion from ‘const void*’ to
‘const geos::geom::Geometry*’ [-fpermissive]
     return GEOSSTRtree_nearest_r( handle, tree, g);
                                 ^

This is because the re-entrant intarface reads:

extern const void GEOS_DLL *GEOSSTRtree_nearest_r(GEOSContextHandle_t handle,
                                                  GEOSSTRtree *tree,
                                                  const GEOSGeometry* geom);

While the non-reentrant:

extern const GEOSGeometry GEOS_DLL *GEOSSTRtree_nearest(GEOSSTRtree *tree,
                                                        const GEOSGeometry* geom)

See the return type is different (void vs Geometry).

[dbaston]

Correct return type for GEOSSTRtree_nearest_r is Geometry*. Looks like the header is incorrect.

Feel free to make GEOSSTRtree_nearest wrap GEOSSTRtree_nearest_r instead of wrapping GEOSSTRtree_nearest_generic

[strk]

In 4303:

Fix GEOSSTRtree_nearest_r signature and add missing implementation

See #796

[strk]

In 4304:

Fix GEOSSTRtree_nearest_r signature and add missing implementation

Closes #796

[Sandro Santilli <strk@…>]

In 3049fb8/git:

Fix GEOSSTRtree_nearest_r signature and add missing implementation

See #796

git-svn-id: ​http://svn.osgeo.org/geos/trunk@4303 5242fede-7e19-0410-aef8-94bd7d2200fb

[Sandro Santilli <strk@…>]

In 3049fb8/git:

Fix GEOSSTRtree_nearest_r signature and add missing implementation

See #796

git-svn-id: ​http://svn.osgeo.org/geos/trunk@4303 5242fede-7e19-0410-aef8-94bd7d2200fb

[Sandro Santilli <strk@…>]

In 3049fb8/git:

Fix GEOSSTRtree_nearest_r signature and add missing implementation

See #796

git-svn-id: ​http://svn.osgeo.org/geos/trunk@4303 5242fede-7e19-0410-aef8-94bd7d2200fb