Opened 8 years ago

Closed 8 years ago

Last modified 6 years ago

#775 closed defect (fixed)

Patch for nmake support for latest Visual Studio compiler (14.0)

Reported by: jmckenna Owned by: geos-devel@…
Priority: major Milestone: 3.5.1
Component: Default Version: 3.5.0
Severity: Unassigned Keywords:
Cc:

Description

  • with MSVC 2015 Update 1 (version 14.0), the following error is returned when executing nmake, with trunk and branch 3.5:
 *** Cannot determine Visual C++ version
 *** Aborting make job

Attachments (1)

nmake.patch (361 bytes ) - added by jmckenna 8 years ago.
handle latest compiler version

Download all attachments as: .zip

Change History (10)

by jmckenna, 8 years ago

Attachment: nmake.patch added

handle latest compiler version

comment:1 by strk, 8 years ago

Resolution: fixed
Status: newclosed

(In [4180]) Handle nmake builds with the latest MSVC

Patch by Jeff McKenna

Closes #775

comment:2 by strk, 8 years ago

Thanks Jeff, committed in trunk with r4180. Do you confirm I got it right ? (written manually as the downloaded patch didn't applie cleanly due to endline mismatches)

comment:3 by jmckenna, 8 years ago

Confirmed with trunk, thanks!

Sorry about the line endings.

comment:4 by jmckenna, 8 years ago

i'll be sure to run dos2unix before posting next time, that should solve this.

comment:5 by strk, 8 years ago

I think it was actually the other way around, as I see CR in the existing files and in my patch. Won't spend too much time on this thing as I don't use nmake myself.

comment:6 by Sandro Santilli <strk@…>, 7 years ago

In 49687a4/git:

Handle nmake builds with the latest MSVC

Patch by Jeff McKenna

Closes #775

git-svn-id: http://svn.osgeo.org/geos/trunk@4180 5242fede-7e19-0410-aef8-94bd7d2200fb

comment:7 by Sandro Santilli <strk@…>, 7 years ago

In 49687a4/git:

Handle nmake builds with the latest MSVC

Patch by Jeff McKenna

Closes #775

git-svn-id: http://svn.osgeo.org/geos/trunk@4180 5242fede-7e19-0410-aef8-94bd7d2200fb

comment:8 by Sandro Santilli <strk@…>, 7 years ago

In 49687a4/git:

Handle nmake builds with the latest MSVC

Patch by Jeff McKenna

Closes #775

git-svn-id: http://svn.osgeo.org/geos/trunk@4180 5242fede-7e19-0410-aef8-94bd7d2200fb

comment:9 by jmckenna, 6 years ago

update: of course this issue exists with the latest Visual Studio compiler (15.0), but switching to the cmake build process avoids this.

Note: See TracTickets for help on using tickets.