Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#764 closed defect (fixed)

PreparedPoint::intersects gives incorrect results for MultiPoint

Reported by: dbaston Owned by: geos-devel@…
Priority: major Milestone: 3.6.1
Component: Default Version: 3.4.2
Severity: Unassigned Keywords:
Cc:

Description

It seems that if a PreparedPoint is build from a MultiPoint, intersects() will return false for any point, for two independent reasons.

a) PreparedPoint::intersects short-circuits to an equality test. It looks like this was introduced at r4081 / r4132.

b) the isAnyTargetComponentInTest method does its work using a PointLocator, which seems to have no implementation for a Point.

Change History (10)

comment:3 by strk, 8 years ago

(In [4149]) Fix incorrect return from PreparedPoint::intersects

Includes unit test

Patch by Daniel Baston via https://github.com/libgeos/libgeos/pull/60

See #764 Reverts r4081

comment:4 by strk, 8 years ago

Milestone: 3.5.13.4.3
Version: 3.5.03.4.2

r4132 if from 3.4 branch, will need to be backported back to that version

comment:5 by strk, 8 years ago

(In [4150]) Fix incorrect return from PreparedPoint::intersects

Includes unit test

Patch by Daniel Baston via https://github.com/libgeos/libgeos/pull/60

See #764 (for 3.5 branch) Reverts r4081

comment:6 by strk, 8 years ago

Resolution: fixed
Status: newclosed

(In [4151]) Fix incorrect return from PreparedPoint::intersects

Includes unit test

Patch by Daniel Baston via https://github.com/libgeos/libgeos/pull/60

Closes #764 (3.4 branch) Reverts r4132

comment:7 by strk, 7 years ago

Milestone: 3.4.33.6.1

Ticket retargeted after milestone deleted

comment:8 by Sandro Santilli <strk@…>, 7 years ago

In d8e7ecbd/git:

Fix incorrect return from PreparedPoint::intersects

Includes unit test

Patch by Daniel Baston via
https://github.com/libgeos/libgeos/pull/60

See #764
Reverts r4081

git-svn-id: http://svn.osgeo.org/geos/trunk@4149 5242fede-7e19-0410-aef8-94bd7d2200fb

comment:9 by Sandro Santilli <strk@…>, 7 years ago

In d8e7ecbd/git:

Fix incorrect return from PreparedPoint::intersects

Includes unit test

Patch by Daniel Baston via
https://github.com/libgeos/libgeos/pull/60

See #764
Reverts r4081

git-svn-id: http://svn.osgeo.org/geos/trunk@4149 5242fede-7e19-0410-aef8-94bd7d2200fb

comment:10 by Sandro Santilli <strk@…>, 7 years ago

In d8e7ecbd/git:

Fix incorrect return from PreparedPoint::intersects

Includes unit test

Patch by Daniel Baston via
https://github.com/libgeos/libgeos/pull/60

See #764
Reverts r4081

git-svn-id: http://svn.osgeo.org/geos/trunk@4149 5242fede-7e19-0410-aef8-94bd7d2200fb

Note: See TracTickets for help on using tickets.