Opened 9 years ago

Closed 5 years ago

Last modified 5 years ago

#714 closed patch (fixed)

[Patch] Don't create default GeometryFactory on the heap

Reported by: smani Owned by: geos-devel@…
Priority: minor Milestone: 3.8.0
Component: Default Version: 3.4.2
Severity: Unassigned Keywords:
Cc:

Description

Nit-pick patch which makes valgrind happier since the default GeometryFactory will be properly freed when the program exists.

Attachments (1)

geos-memleak.patch​ (565 bytes ) - added by smani 9 years ago.
Patch

Download all attachments as: .zip

Change History (13)

by smani, 9 years ago

Attachment: geos-memleak.patch​ added

Patch

comment:1 by strk, 9 years ago

This patch would basically reverts r3632, which looks like something that should have been indeed reverted and evidently wasn't (fully story in #540)

comment:2 by strk, 8 years ago

Milestone: 3.4.3 → 3.6.1

Ticket retargeted after milestone deleted

comment:3 by strk, 7 years ago

Milestone: 3.6.1 → 3.6.2

Ticket retargeted after milestone closed

comment:4 by strk, 7 years ago

Milestone: 3.6.2 → 3.6.3

Ticket retargeted after milestone closed

comment:5 by robe, 6 years ago

Milestone: 3.6.3 → 3.6.4
Priority: major → minor
Type: defect → patch

comment:6 by Sandro Santilli <strk@…>, 5 years ago

Resolution: → fixed
Status: new → closed

In b4126e1/git:

Allocate default geometryfactory on the stack

Makes valgrind happier.
Closes #714

Thanks Sandro Mani

comment:7 by strk, 5 years ago

Milestone: 3.6.4 → 3.8.0

comment:8 by Paul Ramsey <pramsey@…>, 5 years ago

In d17c10d/git:

Allocate default geometryfactory on the stack
Makes valgrind happier.
References #714
Thanks Sandro Mani

comment:9 by Paul Ramsey <pramsey@…>, 5 years ago

In db00eaf/git:

Allocate default geometryfactory on the stack

Makes valgrind happier.
References #714
Thanks Sandro Mani

comment:10 by Paul Ramsey <pramsey@…>, 5 years ago

In 7b6062a/git:

Reverse geomfactory commit
References #714

comment:11 by Paul Ramsey <pramsey@…>, 5 years ago

In c1959da/git:

Reverse geomfactory patch
References #714

comment:12 by pramsey, 5 years ago

I've reverted the commits to branches, since the risk that someone already has software expecting and dealing with a heap-allocated factory outweighs the improvement and valgrind fix.

Note: See TracTickets for help on using tickets.