Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#701 closed defect (fixed)

windows compilation fails due to std::min and std::max and min/max redefinition by windows.h

Reported by: spagooda Owned by: mloskot
Priority: minor Milestone: 3.5.0
Component: Core Version: 3.4.2
Severity: Unassigned Keywords:
Cc:

Description

In the files OffsetCurveSetBuilder.cpp, WKTWriter.cpp, BufferOp.cpp, and LineIntersector.cpp the definition #define NOMINMAX is missing. Additionally an include of <algorithm> might be necessary. On Windows / Visual Studio 2013 the build will fail in the current state.

Change History (5)

comment:1 by spagooda, 10 years ago

sorry, i have no affiliations with the project, so i hope i committed it to the right place.

comment:2 by strk, 10 years ago

This is the right place to submit bugs. It's also a good place to submit patches, if you want a proprietary compiler supported.

comment:3 by mloskot, 9 years ago

Owner: changed from strk to mloskot
Status: newassigned

comment:4 by mloskot, 9 years ago

Milestone: 3.4.33.5.0

comment:5 by mloskot, 9 years ago

Resolution: fixed
Status: assignedclosed

Cleaned up in trunk (r4064)

Last edited 9 years ago by mloskot (previous) (diff)
Note: See TracTickets for help on using tickets.