Non-standard ChangeLog file in 3.4.0 and 3.4.1 releases

[strk]

It's been noticed that the ChangeLog file changed a lot between trunk and 3.4 branch. In particular, I tracked this down to r3890 which removed filenames from the entries.

Regina: was the file generated by "make cl" ? What version of svn2cl do you have ?

The version I use is svn2cl 0.11

I've also noted that other iterations of ChangeLog updates from you (r3868, r3867) did retain the filenames. Ideas ?

[robe]

Yes was generated by make cl.

Version I used was 0.13

[robe]

FWIW in my svn2cl I see these settings which I did not change:

STRIPPREFIX="AUTOMATICALLY-DETERMINED"
LINELEN=75
GROUPBYDAY="no"
INCLUDEREV="no"
BREAKBEFOREMSG="no"
REPARAGRAPH="no"
SEPARATEDAYLOGS="no"
ACTIONS="no"
CHANGELOG=""
OUTSTYLE="cl"
SVNLOGCMD="svn --verbose --xml log"
SVNINFOCMD="svn --non-interactive info"
AUTHORSFILE=""
IGNORE_MESSAGE_STARTING=""
TITLE="ChangeLog"
REVISION_LINK="#r"
TICKET_LINK=""
TMPFILES=""

Was I supposed to change any. What are yours set to?

[strk]

Where do you see those settings ?

[robe]

at the top of the svn2cl.sh file

[strk]

# svn2cl version
VERSION="0.11"

# set default parameters
PWD=`pwd`
STRIPPREFIX="AUTOMATICALLY-DETERMINED"
LINELEN=75
GROUPBYDAY="no"
INCLUDEREV="no"
BREAKBEFOREMSG="no"
REPARAGRAPH="no"
SEPARATEDAYLOGS="no"
ACTIONS="no"
CHANGELOG=""
OUTSTYLE="cl"
SVNLOGCMD="svn --non-interactive --verbose --xml log"
SVNINFOCMD="svn --non-interactive info"
AUTHORSFILE=""
IGNORE_MESSAGE_STARTING=""
TITLE="ChangeLog"
REVISION_LINK="#r"
TMPFILES=""
AWK="awk"

Could you run "make cl" again and check that it includes the filenames ?

[robe]

yes it seem to output the file names now. What did you change?

[strk]

I didn't change anything. Maybe you didn't use "make cl" before ? Generally, it is good to review changes before committing them. Changes in the ChangeLog file should always only be additions, not modifications of old lines.