Opened 9 years ago

Closed 5 years ago

#648 closed enhancement (worksforme)

Change svn/git line breaks to Unix

Reported by: robe Owned by: geos-devel@…
Priority: minor Milestone: 3.7.0
Component: Default Version: 3.4.0
Severity: Unassigned Keywords:
Cc:

Description

It's too late for this round, but I believe I have come up with a fix that will allow me to build tar balls under mingw windows (#645). It's a "Treat me like a Unix user" not a windows or Mac user.

The issue I see it is that svn because it defaults the line break to native mode -- it sees me as a Windows user and kindly pulls all the files down with windows linebreaks. In most cases, windows doesn't actually care the line break (I haven't checked VS so we may need to make special provision). If VS cares, then its already screwed by the tar ball which is Unix linebreaks.

It's only Unix/Linux that are picky.

So solution, change all files to eol-style=LF. I believe there is an equivalent for git.

Does anyone see an issue with this?

Change History (6)

comment:1 by Mike Taves, 9 years ago

I think it would be overkill to convert all files to have LF eol-style. There is only a few files that require LF only, such as shell scripts and other files processed by Perl (I think). The majority of files are OK with eol-style=native.

I can come up with a list of SVN property changes, but not in the next bit of time.

The bzip2 packaging OS must either be a POSIX system, or one that SVN can configured as LF system (Tortoise SVN can do this?). Git on Windows can be configured to either convert or keep EOLs, but it doesn't use properties in the same way SVN does.

comment:2 by robe, 9 years ago

Mike,

thanks for the input. No rush on change since next at best will be 3.4.1 or 3.5. That would be very helpful if you can come up with SVN properties. I think we have such for PostGIS so it for example doesn't fiddle with the sql files.

On note of Tortoise, maybe it does. Haven't looked. I've been using the svn and git of late with the latest msys since that provides me a single install with everything Posix I can tag along on my usb stick and enjoy the Open source offerings I've grown accustom to. Those are both commandline only and haven't looked to see what switches they provide. I presume they provide the same switches as what the Unix/Linux ones have.

comment:3 by robe, 7 years ago

hmm well if I am to do a release I guess I'll have to find a way around this.

comment:4 by robe, 7 years ago

Milestone: 3.5.03.6.0

comment:5 by strk, 6 years ago

Milestone: 3.6.03.7.0

Ticket retargeted after milestone closed

comment:6 by robe, 5 years ago

Resolution: worksforme
Status: newclosed

no longer an issue.

Note: See TracTickets for help on using tickets.