Changes between Initial Version and Version 4 of Ticket #638


Ignore:
Timestamp:
Aug 5, 2013, 1:49:19 PM (9 years ago)
Author:
robe
Comment:

Not seeing this particular error on my mingw gcc 4.8 built with cmake. Though I do see this somewhat troubling notice

In file included from c:/jenkins/geos/branches/3.4cmake/tests/xmltester/BufferResultMatcher.cpp:22:0:
C:/jenkins/geos/branches/3.4cmake/include/geos/geom/BinaryOp.h: In instantiation of 'std::auto_ptr<geos::geom::Geometry> geos::geom::BinaryOp(const geos::geom::Geometry*, const geos::geom::Geometry*, BinOp) [with BinOp = geos::operation::overlay::overlayOp]':
c:/jenkins/geos/branches/3.4cmake/tests/xmltester/BufferResultMatcher.cpp:80:58:   required from here
C:/jenkins/geos/branches/3.4cmake/include/geos/geom/BinaryOp.h:459:32: warning: overflow in implicit constant conversion [-Woverflow]
   long unsigned int maxScale = 1e16;

I'd just assume avoid these changes in a micro release especially since we plan to release soon and sounds like a lot of changes would need to be made to accommodate this. Pushing to 3.5

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #638

    • Property Milestone3.5.0
  • Ticket #638 – Description

    initial v4  
     1
    12I recommend that for all asserts with strings, that they be changed to wrap the string in a static_cast.  Not very exciting, but it makes the stricter compilers happier.
    23