Opened 11 years ago
Last modified 7 years ago
#638 closed defect
Recommend a static_cast around assert strings — at Initial Version
| Reported by: | goatbar | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 3.7.0 |
| Component: | Default | Version: | 3.3.8 |
| Severity: | Unassigned | Keywords: | |
| Cc: |
Description
I recommend that for all asserts with strings, that they be changed to wrap the string in a static_cast. Not very exciting, but it makes the stricter compilers happier.
e.g. in src/geom/util/GeometryEditor.cpp
assert(!"SHOULD NEVER GET HERE");
changes to
assert(!static_cast<bool>("SHOULD NEVER GET HERE"));
Note:
See TracTickets
for help on using tickets.
