Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#634 closed defect (fixed)

geos_svn_revision.h being regenerated with bad one

Reported by: robe Owned by: mloskot
Priority: minor Milestone: 3.4.0
Component: Build/Install (cmake) Version: master
Severity: Unassigned Keywords:
Cc:

Description

I'm not sure what triggers this but on my mingw64 builds the revision number is always being overwritten with 0. I built from tar ball this time and it still insists on trying to pull from svn when I'm building with CMake and then overwrite the good packaged

geos_svn_revision.h (that has a number with 0)

Is there a way to turn this off or have it not do it when you are building from tar ball?

Change History (4)

comment:1 Changed 7 years ago by robe

Component: DefaultBuild/Install (cmake)
Owner: changed from geos-devel@… to mloskot

forgot to tag this as cmake

comment:2 Changed 7 years ago by mloskot

Resolution: fixed
Status: newclosed

Zero means, it was impossible to generate any meaningful value. Thus, CMake configuration warns users, as per lines from CMakeLists.txt:250:

message("*** sh-compatible command not found, cannot create geos_svn_revision.h")
message("*** Check SVN revision and create revision header manually:")
message("*** echo '#define GEOS_SVN_REVISION XYZ' > ${CMAKE_SOURCE_DIR}/geos_svn_revision.h")

comment:3 Changed 7 years ago by robe

I don't have issue with that. What I do have issue with (and I'll double-check), is that when it registers that error, it overwrites the geos_svn_revision.h that is packaged before it copies it. I'll double-check to make sure I didn't sneak in a sh autogen.sh by accident (could be user error I admit).

comment:4 Changed 7 years ago by robe

This is only an issue building from tar ball for me. And pet peeve, if you aren't going to fix this, you should mark this as wontfix rather than fixed :)

Note: See TracTickets for help on using tickets.