Opened 8 years ago

Closed 8 years ago

#608 closed defect (fixed)

IsValidOp should return eNestedShells not eNestedHoles at ln 530

Reported by: geomworx Owned by: geos-devel@…
Priority: minor Milestone: 3.3.9
Component: Default Version: 3.3.6
Severity: Unassigned Keywords: history 3.3.8
Cc:

Description

Stepping through code, I believe that inside 3rd_geos\IsValidOp?.cpp::checkShellNotNested(), on line 530, the keyword:

eNestedHoles

should be replaced by:

eNestedShells

Since the error detected here is shells being nested, not holes being nested.

Change History (1)

comment:1 Changed 8 years ago by strk

Keywords: history 3.3.8 added
Milestone: 3.3.73.3.x
Resolution: fixed
Status: newclosed

Good catch ! Fixed by r3755 in trunk and r3756 in 3.3 branch It surely reveals poor automated testing .. :(

Note: See TracTickets for help on using tickets.