Opened 11 years ago

Closed 11 years ago

#606 closed defect (wontfix)

Compile error on Win64 BufferOp.cpp

Reported by: robert666 Owned by: mloskot
Priority: major Milestone: 3.3.7
Component: Build/Install (cmake) Version: 3.3.6
Severity: Unassigned Keywords:
Cc:

Description (last modified by mloskot)

Hi all

I hope this is the right place to report a compile error in GEOS.

I use CMake and Visual Studio 2012 and try to build an x64 build of GEOS 3.3.6, but I get

D:\CMake_Build\I3D\EXTERNALS\Source\GEOS\src\operation\buffer\BufferOp.cpp(91): error C2589: '(' : illegal token on right side of '::'
2>  
2>D:\CMake_Build\I3D\EXTERNALS\Source\GEOS\src\operation\buffer\BufferOp.cpp(91): error C2059: syntax error : '::'
2>  

Can you fix this?

Cheers, Robert

Change History (3)

comment:1 by mloskot, 11 years ago

Description: modified (diff)
Resolution: worksforme
Status: newclosed

comment:2 by robert666, 11 years ago

Resolution: worksforme
Status: closedreopened

It is not working with Visual Studio 2012 because in \CMakeLists.txt, ln 125, NOMINMAX is only added to VS prior 2012, so the easiest solution would be to change line 125 to

if(MSVC80 OR MSVC90 OR MSVC10 OR MSVC11)

Then, I can successfully compile GEOS on Visual Studio 2012.

Regards

comment:3 by mloskot, 11 years ago

Resolution: wontfix
Status: reopenedclosed

I see. I don't have any means to test and fix it now myself

However, I have clarified CMake status on the BuildingOnWindowsWithCMake wiki. Please only file tickets against CMake if willing to provide a patch. Feel free to reopen if you'd like to submit a patch.

Note: See TracTickets for help on using tickets.