Opened 11 years ago

Closed 11 years ago

#500 closed defect (fixed)

default initialization of an object of const type 'const geos::operation::overlay::OverlayNodeFactory' requires a user-provided default constructor

Reported by: hobu Owned by: geos-devel@…
Priority: minor Milestone: 3.3.2
Component: Default Version: 3.3.1
Severity: Unassigned Keywords:
Cc:

Description

clang reports:

OverlayNodeFactory.cpp:31:33: error: default initialization of an object of const type 'const geos::operation::overlay::OverlayNodeFactory' requires a user-provided default
      constructor

Attachments (1)

OverlayNodeFactory_singleton.patch (677 bytes ) - added by strk 11 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 by strk, 11 years ago

OverlayNodeFactory does have a user-provided default constructor. Only it is inlined (it's in OverlayNodeFactory.h).

Anyway, does moving the static into the ::instance() method fixes the build with clang ? See attached patch.

comment:2 by hobu, 11 years ago

Yes this fixes clang's complaint. Committed to 3.3 branch in r3545.

comment:3 by strk, 11 years ago

Hobu: could you please also commit an entry in the NEWS file about this ? And a forward port to trunk would also be nice. Thank you!

comment:4 by hobu, 11 years ago

confirmed fix and applied in trunk in r3546

comment:5 by hobu, 11 years ago

Resolution: fixed
Status: newclosed

note added in 3.3 branche NEWs in r3547

Note: See TracTickets for help on using tickets.