Opened 11 years ago

Closed 10 years ago

Last modified 9 years ago

#487 closed enhancement (fixed)

Port Delaunay Triangulation API from JTS

Reported by: strk Owned by: geos-devel@…
Priority: major Milestone: 3.4.0
Component: Default Version: main
Severity: Unassigned Keywords: history
Cc: mateusz@…, blc56, woodbri

Description (last modified by strk)

Delaunay triangulation is a big new package in JTS 1.11 which wasn't ported out yet. It consists in 26 new classes + 3 testcases at the C++ level.

Attachments (2)

delaunay.patch (103.8 KB ) - added by blc56 10 years ago.
delaunayv1.patch (103.7 KB ) - added by blc56 10 years ago.

Download all attachments as: .zip

Change History (19)

comment:1 by strk, 11 years ago

Description: modified (diff)

comment:3 by mloskot, 11 years ago

Cc: mateusz@… added

by blc56, 10 years ago

Attachment: delaunay.patch added

comment:4 by blc56, 10 years ago

I've attached a patch which implements enough of Delaunay Triangulation to get a functioning DelaunayTriangulationBuilder class. It includes the DelaunayTest testcase. The patch is also available in my libgeos fork on github: https://github.com/blc56/libgeos

Comments and criticism are welcome. Thanks!

Ben

comment:5 by blc56, 10 years ago

Cc: blc56 added

comment:6 by strk, 10 years ago

A couple of things I noticed:

  1. You assigned the copyright to Refractions Research in 2006
  2. The "Last port" line should contain the SVN revision id of the JTS file you ported

didn't look at the actual code yet (will do as soon as I find a few hours)

Thanks for contributing, btw :)

comment:7 by woodbri, 10 years ago

Cc: woodbri added

comment:8 by blc56, 10 years ago

Thanks! I've attached an patch with updated copyright attributions and JTS svn revisions. I can change the copyright attribution as necessary to facilitate inclusion.

by blc56, 10 years ago

Attachment: delaunayv1.patch added

comment:9 by strk, 10 years ago

Your patch is fully in as of r3693

Next stop: C API exposure

comment:10 by strk, 10 years ago

Benjamin: very good job, I very much like the way you followed existing style and took care of memory leaks :)

comment:11 by strk, 10 years ago

and const correctness too !

comment:12 by strk, 10 years ago

Resolution: fixed
Status: newclosed

comment:13 by strk, 10 years ago

#565 is about the C-API exposure

comment:14 by strk, 10 years ago

Benjamin: I noticed the triangulation does not retain the Z value. Is this the case in JTS as well ?

comment:15 by blc56, 10 years ago

I'm not sure off the top of my head. I'll check on the JTS behavior. I'll be able to get to it before the end of next week.

comment:16 by strk, 10 years ago

I created #570 for that, please followup there. Thanks!

comment:17 by robe, 9 years ago

Keywords: history added
Note: See TracTickets for help on using tickets.