Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#280 closed task (fixed)

trunk nmake should be modified

Reported by: sanak Owned by:
Priority: major Milestone: 3.2.0
Component: Build/Install Version: main
Severity: Unassigned Keywords: nmake
Cc: warmerdam

Description

Svn trunk nmake related files(makefile.vc .etc) should be modified, because "__declspec(dllexport)" definition must be set manually by r2556 and #273 modification.

I had made sample patch for this problem, but expert's review is necessary.

Regards,

Attachments (2)

fix-nmake.patch (4.8 KB ) - added by sanak 14 years ago.
TortoiseSVN(Encoding:Shift_JIS)
fix-nmake-simple.patch (3.0 KB ) - added by sanak 13 years ago.
TortoiseSVN(Shift_JIS)

Download all attachments as: .zip

Change History (9)

by sanak, 14 years ago

Attachment: fix-nmake.patch added

TortoiseSVN(Encoding:Shift_JIS)

comment:1 by pramsey, 14 years ago

Owner: changed from pramsey to mloskot

comment:2 by warmerdam, 13 years ago

Cc: warmerdam added

comment:3 by mloskot, 13 years ago

Owner: mloskot removed

comment:4 by strk, 13 years ago

Anyone using nmake willing to review this ? Frank ?

by sanak, 13 years ago

Attachment: fix-nmake-simple.patch added

TortoiseSVN(Shift_JIS)

comment:5 by sanak, 13 years ago

Sorry, my previous patch may be complex. I had added new one simple(fix-nmake-simple.patch), so please check this one for the problem that geos.dll and geos_c.dll from current nmake export nothing.

Regards,

comment:6 by sanak, 13 years ago

Resolution: fixed
Status: newclosed

I had confirmed that this problem was fixed at r2670. Thanks warmerdam, for quickly fix.

Regards,

comment:7 by warmerdam, 13 years ago

Wow, you beat me to updating the ticket, while I struggled with connection problems! I would add that the revision was accidentally misattributed to #288.

Note: See TracTickets for help on using tickets.