Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#268 closed defect (fixed)

nullCoord defunition mixes static and dllimport

Reported by: mloskot Owned by: mloskot
Priority: blocker Milestone: 3.2.0
Component: Core Version: main
Severity: Unassigned Keywords: dllimport, static
Cc:

Description (last modified by mloskot)

Building of trunk r2600 using Visual C++ 8.0 fails with the following error:

geom\Coordinate.cpp(31) : error C2491: 'geos::geom::Coordinate::nullCoord' : 
   definition of dllimport static data member not allowed

Attachments (2)

fix-msvc-sync90-80.patch (21.5 KB ) - added by sanak 15 years ago.
TortoiseSVN(Japanese)
fix-msvc-sync90-80_r2609.patch (19.9 KB ) - added by sanak 15 years ago.
TortoiseSVN(Japanese)

Download all attachments as: .zip

Change History (9)

comment:1 by mloskot, 15 years ago

Description: modified (diff)

by sanak, 15 years ago

Attachment: fix-msvc-sync90-80.patch added

TortoiseSVN(Japanese)

comment:2 by sanak, 15 years ago

I think that this problem is related to r2556.

I had make patch for msvc80 sync to msvc90.

Regards,

comment:3 by pramsey, 15 years ago

Owner: changed from geos-devel@… to mloskot

comment:4 by pramsey, 15 years ago

Milestone: 3.2.0

by sanak, 15 years ago

TortoiseSVN(Japanese)

comment:5 by sanak, 15 years ago

mloskot, strk,

I had updated previous patch.
Modified points are as follows.

  • Add GEOS_DLL_EXPORT definition to geos_c_dll.vcproj.
  • Synchronise geos_lib.vcproj and geos_unit.vcproj to msvc90 ones.

Please see #273 for details.

Regards,

comment:6 by mloskot, 15 years ago

Resolution: fixed
Status: newclosed

OK for me. Closing

p.s. sorry for delay - holidays

in reply to:  6 comment:7 by sanak, 15 years ago

mloskot,

Sorry, my explanation was insufficiency. The msvc90 projects was fixed at #273, but the msvc80 projects need update for the latest trunk. (algorithm/distance/DiscreteHausdorffDistance.cpp .etc)

But the original issue of this ticket is "dllimport" problem, So should I create new ticket for msvc80 sync problem and attach fix-msvc-sync90-80_r2609.patch ?

Regards,

Note: See TracTickets for help on using tickets.