Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#1103 closed defect (fixed)

Target "tinyxml2" of type OBJECT_LIBRARY may not be linked into another target.

Reported by: strk Owned by: geos-devel@…
Priority: blocker Milestone: 3.10.0
Component: Build/Install (cmake) Version: main
Severity: Critical Keywords:
Cc:

Description (last modified by strk)

$ git describe --tags
3.9.0beta2-239-g89886fb23
$ cmake --version
cmake version 3.10.2
$ cmake .. 2>&1 | grep -A4 Error
CMake Error at tests/xmltester/CMakeLists.txt:30 (target_link_libraries):
  Target "tinyxml2" of type OBJECT_LIBRARY may not be linked into another
  target.  One may link only to STATIC or SHARED libraries, or to executables
  with the ENABLE_EXPORTS property set.

Marking it as having Severity = Critical because it worked just fine with autotools but autotools have been removed from master branch, so I basically cannot build anymore until this is fixed.

Change History (8)

comment:1 by strk, 3 years ago

Description: modified (diff)
Priority: majorblocker

comment:2 by dbaston, 3 years ago

It looks like changes ( 3dd7121 ) I introduced to quiet compiler warnings in vendored libraries require CMake 3.13. So this can be solved either by updating cmake_minimum_required to 3.13, or reverting those changes and accepting that we cannot use -Werror because of warnings from vendored libraries.

comment:3 by dbaston, 3 years ago

Milestone: 3.9.23.10.0

comment:4 by strk, 3 years ago

Please lower the requirement, lowering entry barrier for devs

comment:5 by strk, 3 years ago

Reverting merge commit 3dd7121 (picking parent index 1) seems to fix the error (but reverts a lot of things)

comment:7 by strk, 3 years ago

Resolution: fixed
Status: newclosed

comment:8 by Paul Ramsey <pramsey@…>, 3 years ago

In f65bb35/git:

Use OBJECT library to build ryu, so it can be fully included in
static libgeos.a, and up the cmake requirement to 3.13 to support
that change. References #1103

Note: See TracTickets for help on using tickets.